Skip to content

Commit f228187

Browse files
committed
Change references from Docker to Container.
Docker container -> container Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
1 parent a81f242 commit f228187

File tree

22 files changed

+37
-37
lines changed

22 files changed

+37
-37
lines changed

HACKING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ costly setup those components should be tested in isolation.
200200

201201
We break integration tests into two categories, those that use Docker and those
202202
that do not. In general, high-level components that depend on the behavior of code
203-
running inside a Docker container should have at least one or two integration tests
203+
running inside a container should have at least one or two integration tests
204204
that test all the way down to Docker, but those should be part of their own
205205
test suite. Testing the API and high-level API functions should generally
206206
not depend on calling into Docker. They are denoted by special test tags and

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ The latest OKD Origin images are published to the Docker Hub under the `openshif
5050

5151
### Concepts
5252

53-
OKD builds a developer-centric workflow around Docker containers and Kubernetes runtime concepts. An **Image Stream** lets you easily tag, import, and publish Docker images from the integrated registry. A **Build Config** allows you to launch Docker builds, build directly from source code, or trigger Jenkins Pipeline jobs whenever an image stream tag is updated. A **Deployment Config** allows you to use custom deployment logic to rollout your application, and Kubernetes workflow objects like **DaemonSets**, **Deployments**, or **StatefulSets** are upgraded to automatically trigger when new images are available. **Routes** make it trivial to expose your Kubernetes services via a public DNS name. As an administrator, you can enable your developers to request new **Projects** which come with predefined roles, quotas, and security controls to fairly divide access.
53+
OKD builds a developer-centric workflow around containers and Kubernetes runtime concepts. An **Image Stream** lets you easily tag, import, and publish Docker images from the integrated registry. A **Build Config** allows you to launch Docker builds, build directly from source code, or trigger Jenkins Pipeline jobs whenever an image stream tag is updated. A **Deployment Config** allows you to use custom deployment logic to rollout your application, and Kubernetes workflow objects like **DaemonSets**, **Deployments**, or **StatefulSets** are upgraded to automatically trigger when new images are available. **Routes** make it trivial to expose your Kubernetes services via a public DNS name. As an administrator, you can enable your developers to request new **Projects** which come with predefined roles, quotas, and security controls to fairly divide access.
5454

5555
For more on the underlying concepts of OKD, please see the [documentation site](https://docs.okd.io/latest/welcome/index.html).
5656

@@ -103,7 +103,7 @@ OKD runs with the following security policy by default:
103103
* By default, Docker builds can (and often do) run as root. You can control who can create Docker builds through the `builds/docker` and `builds/custom` policy resource.
104104
* Regular users and project admins cannot change their security quotas.
105105

106-
Many Docker containers expect to run as root (and therefore edit all the contents of the filesystem). The [Image Author's guide](https://docs.okd.io/latest/creating_images/guidelines.html#openshift-specific-guidelines) gives recommendations on making your image more secure by default:
106+
Many containers expect to run as root (and therefore edit all the contents of the filesystem). The [Image Author's guide](https://docs.okd.io/latest/creating_images/guidelines.html#openshift-specific-guidelines) gives recommendations on making your image more secure by default:
107107

108108
* Don't run as root
109109
* Make directories you want to write to group-writable and owned by group id 0

Vagrantfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,14 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
205205
rsync__args: %w(--verbose --archive --delete),
206206
rsync__exclude: dest["exclude"],
207207
type: vagrant_openshift_config['sync_folders_type'],
208-
nfs_udp: false # has issues when using NFS from within a docker container
208+
nfs_udp: false # has issues when using NFS from within a container
209209
end
210210
else
211211
config.vm.synced_folder sync_from, sync_to,
212212
rsync__args: %w(--verbose --archive --delete),
213213
rsync__exclude: vagrant_openshift_config["sync_folders_rsync_exclude"],
214214
type: vagrant_openshift_config['sync_folders_type'],
215-
nfs_udp: false # has issues when using NFS from within a docker container
215+
nfs_udp: false # has issues when using NFS from within a container
216216
end
217217
end
218218

docs/builds.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Problem/Rationale
44

5-
Kubernetes creates Docker containers from images that were built elsewhere and pushed to a Docker registry. Building Docker images is a foundational use-case in Docker-based workflows for application development and deployment. Without support for builds in Kubernetes, if a system administrator wanted a system that could build images, he or she would have to select a pre-existing build system or write a new one, and then figure out how to deploy and maintain it on or off Kubernetes. However, in most cases operators would wish to leverage the ability of Kubernetes to schedule task execution into a pool of available resources, and most build systems would want to take advantage of that mechanism.
5+
Kubernetes creates containers from images that were built elsewhere and pushed to a Docker registry. Building Docker images is a foundational use-case in Docker-based workflows for application development and deployment. Without support for builds in Kubernetes, if a system administrator wanted a system that could build images, he or she would have to select a pre-existing build system or write a new one, and then figure out how to deploy and maintain it on or off Kubernetes. However, in most cases operators would wish to leverage the ability of Kubernetes to schedule task execution into a pool of available resources, and most build systems would want to take advantage of that mechanism.
66

77
Offering an API for builds makes OpenShift a viable back-end for arbitrary third-party Docker image build systems which require resource constraints and scheduling capabilities, and allows organizations to orchestrate Docker builds from their existing continuous integration processes. OpenShift enables CI/CD flows around Docker images.
88

@@ -57,7 +57,7 @@ There are viable paths to alleviate or resolve each of these disadvantages, and
5757

5858
##### Why not Docker-in-Docker?
5959

60-
It's theoretically possible to implement builds using a nested Docker daemon within a Docker container (Docker-in-Docker). On the surface, this approach offers some compelling advantages:
60+
It's theoretically possible to implement builds using a nested Docker daemon within a container (Docker-in-Docker). On the surface, this approach offers some compelling advantages:
6161

6262
1. Build process resources can be naturally constrained to the user’s acceptable limits (cgroups)
6363
2. Containers created during the build have the build container as their parent process, making container cleanup simple

docs/debugging-openshift.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ and you can get the build id via:
4747

4848
the build id is in the first column.
4949

50-
If you're unable to retrieve the logs in this way, you can also get them directly from docker. First you need to find the docker container that ran your build:
50+
If you're unable to retrieve the logs in this way, you can also get them directly from docker. First you need to find the container that ran your build:
5151

5252
$ docker ps -a | grep builder
5353

@@ -119,7 +119,7 @@ Obviously this won't work if you don't have bash installed but you could always
119119
Name Resolution Within Containers
120120
-------------------
121121

122-
DNS related services like `dnsmasq` can interfere with naming resolution in the Docker containers launched by OpenShift, including binding on the same port (53) that OpenShift will attempt to use. To circumvent this conflict, disable
122+
DNS related services like `dnsmasq` can interfere with naming resolution in the containers launched by OpenShift, including binding on the same port (53) that OpenShift will attempt to use. To circumvent this conflict, disable
123123
these services. Using the `dnsmasq` example on Fedora, run all three of the following before starting OpenShift to ensure `dnsmasq` is not running, does not launch later on, and hence does not interfere with OpenShift:
124124

125125
$ sudo systemctl stop dnsmasq

docs/images.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# OpenShift Images
22
## Problem/Rationale
3-
Kubernetes creates Docker containers from images stored in Docker registries. It does not currently track and store any information about images; it merely pulls and stores them locally on a minion as part of the pod creation process.
3+
Kubernetes creates containers from images stored in Docker registries. It does not currently track and store any information about images; it merely pulls and stores them locally on a minion as part of the pod creation process.
44

55
Adding information related to images - image repositories, the images themselves, tags, and metadata - as resources in an image component will provide foundational support for several use cases, listed below.
66

examples/sample-app/README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ equivalent for your host platform/architecture), you have that and its
99
symlink/copy `oc` in your `PATH` and root's, and Docker is installed and
1010
working. See https://github.com/openshift/origin/blob/master/CONTRIBUTING.adoc.
1111

12-
Alternatively, if you are using the openshift/origin Docker container, please
12+
Alternatively, if you are using the openshift/origin container, please
1313
make sure you follow these instructions first:
1414
https://github.com/openshift/origin/blob/master/examples/sample-app/container-setup.md
1515

1616
Security Warning
1717
----------------
18-
OpenShift no longer requires SElinux to be disabled, however OpenShift is a system which runs Docker containers on your system. In some cases (build operations and the registry service) it does so using privileged containers. Furthermore those containers access your host's Docker daemon and perform `docker build` and `docker push` operations. As such, you should be aware of the inherent security risks associated with performing `docker run` operations on arbitrary images as they effectively have root access. This is particularly relevant when running the OpenShift nodes directly on your host system.
18+
OpenShift no longer requires SElinux to be disabled, however OpenShift is a system which runs containers on your system. In some cases (build operations and the registry service) it does so using privileged containers. Furthermore those containers access your host's Docker daemon and perform `docker build` and `docker push` operations. As such, you should be aware of the inherent security risks associated with performing `docker run` operations on arbitrary images as they effectively have root access. This is particularly relevant when running the OpenShift nodes directly on your host system.
1919

2020
For more information, see these articles:
2121

@@ -415,7 +415,7 @@ Another interesting example is deleting a pod.
415415

416416
$ oc delete pod frontend-1-votq4
417417

418-
- Verify that the pod has been removed by listing the available pods. This also stopped the associated Docker container, you can check using the command:
418+
- Verify that the pod has been removed by listing the available pods. This also stopped the associated container, you can check using the command:
419419

420420
$ docker ps -a
421421
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
@@ -430,6 +430,6 @@ To clean up all of your environment, you can run the script:
430430

431431
$ sudo ./cleanup.sh
432432

433-
This will stop the `openshift` process, remove files created by OpenShift and kill all Docker containers created by Kubernetes in your host system. The cleanup script needs root privileges to be able to remove all the directories OpenShift created.
433+
This will stop the `openshift` process, remove files created by OpenShift and kill all containers created by Kubernetes in your host system. The cleanup script needs root privileges to be able to remove all the directories OpenShift created.
434434

435-
**Use with caution!** Any Docker container prefixed with "k8s_" will be killed by this script.
435+
**Use with caution!** Any container prefixed with "k8s_" will be killed by this script.

examples/sample-app/cleanup.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
echo "Killing openshift all-in-one server ..."
44
sudo pkill -x openshift
55

6-
echo "Stopping all k8s docker containers on host ..."
6+
echo "Stopping all k8s containers on host ..."
77
sudo docker ps --format='{{.Names}}' | grep -E '^k8s_' | xargs -l -r sudo docker stop
88

99
echo "Unmounting openshift local volumes ..."

examples/sample-app/container-setup.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ things to get it going.
55

66
## Download and Run OpenShift Origin
77
If you have not already, perform the following to (download and) run the Origin
8-
Docker container:
8+
container:
99

1010
$ docker run -d --name "openshift-origin" --net=host --privileged \
1111
-v /var/run/docker.sock:/var/run/docker.sock \
@@ -46,7 +46,7 @@ you know where you are:
4646
$ PS1="openshift-dock: [\u@\h \W]\$ "
4747

4848
## Get the Sample Application Code
49-
Inside the OpenShift Docker container, you'll need to fetch some of the code
49+
Inside the OpenShift container, you'll need to fetch some of the code
5050
bits that are used in the sample app.
5151

5252
$ cd /var/lib/openshift

examples/storage-examples/gluster-examples/nginx_gluster_host/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ _Under volumes_
171171
*Notice we also see our `helloworld.html` file that we created within that directory*
172172

173173

174-
- Enter a simple curl command from the docker container to serve the page
174+
- Enter a simple curl command from the container to serve the page
175175

176176

177177
curl http://10.1.0.9/test/helloworld.html

examples/storage-examples/gluster-examples/nginx_gluster_plugin/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ _Under volumes_
235235

236236

237237

238-
- Enter simple curl command from the docker container to serve the page
238+
- Enter simple curl command from the container to serve the page
239239

240240

241241
curl http://10.1.0.10/test/glusterfs-nginx/helloworld.html

examples/storage-examples/gluster-examples/nginx_gluster_pvc/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ At this point, all [environment assumptions](../../gluster-examples) are met, an
268268
*Notice we also see our helloworld.html file that we created within that directory*
269269

270270

271-
- Enter simple curl command from the docker container to serve the page
271+
- Enter simple curl command from the container to serve the page
272272

273273
curl http://10.1.0.12/test/glusterfs-nginx-pvc/helloworld.html
274274

examples/storage-examples/gluster-examples/nginx_template/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ _Also, take note that for this simple example, we are simply creating a pod that
178178
*Notice we also see our helloworld.html file that we created within that directory*
179179

180180

181-
- Enter simple curl command from the docker container to serve the page
181+
- Enter simple curl command from the container to serve the page
182182

183183
curl http://10.1.0.12/test/gluster-nginx-pvc-template/helloworld.html
184184

examples/storage-examples/host-path-examples/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ _Under volumes_
110110
hello.html *helloworld.html*
111111

112112

113-
- Enter simple curl command from the docker container to serve the page
113+
- Enter simple curl command from the container to serve the page
114114

115115
curl http://10.1.0.2/test/helloworld.html
116116

hack/dind-cluster.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -1069,11 +1069,11 @@ case "${1:-""}" in
10691069
10701070
Commands:
10711071
- start: Starts the containers in an openshift docker-in-docker environment
1072-
- stop: Destroys the docker containers for the docker-in-docker environment
1072+
- stop: Destroys the containers for the docker-in-docker environment
10731073
- add-node: Adds a node to the cluster
10741074
- delete-node <node-num>: Deletes the given node from the cluster
10751075
- refresh: Refreshes the openshift binaries in the containers and reloads the processes
1076-
- ps: List all of the docker containers that make up the cluster
1076+
- ps: List all of the containers that make up the cluster
10771077
- pause: Stops running containers, but leaves the state around
10781078
- resume: Restarts paused containers
10791079
- copy-image: Copies an image from the outer docker into all node dockers

hack/env

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22

3-
# This starts a Docker container using the release image (openshift/origin-release:golang-1.8)
3+
# This starts a container using the release image (openshift/origin-release:golang-1.8)
44
# and syncs the local directory into that image. The default mode performs a 'git archive' of
55
# the current HEAD, so you get a reproducible environment. You can also set
66
# OS_BUILD_ENV_REUSE_VOLUME to a docker volume name to rsync (or docker cp) the contents of
@@ -39,4 +39,4 @@ relative_script_path="$( os::util::repository_relative_path "${OS_OUTPUT_SCRIPTP
3939
default_preserve_paths="${relative_bin_path}:${relative_release_path}:${relative_script_path}"
4040
export OS_BUILD_ENV_PRESERVE="${OS_BUILD_ENV_PRESERVE:-"${default_preserve_paths}"}"
4141

42-
os::build::environment::run "$@"
42+
os::build::environment::run "$@"

hack/lib/cleanup.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ function os::cleanup::containers() {
120120
return
121121
fi
122122

123-
os::log::info "[CLEANUP] Stopping docker containers"
123+
os::log::info "[CLEANUP] Stopping containers"
124124
for id in $( os::cleanup::internal::list_our_containers ); do
125125
os::log::debug "Stopping ${id}"
126126
docker stop "${id}" >/dev/null
@@ -130,7 +130,7 @@ function os::cleanup::containers() {
130130
return
131131
fi
132132

133-
os::log::info "[CLEANUP] Removing docker containers"
133+
os::log::info "[CLEANUP] Removing containers"
134134
for id in $( os::cleanup::internal::list_our_containers ); do
135135
os::log::debug "Removing ${id}"
136136
docker rm --volumes "${id}" >/dev/null
@@ -166,7 +166,7 @@ function os::cleanup::dump_container_logs() {
166166
readonly -f os::cleanup::dump_container_logs
167167

168168
# os::cleanup::internal::list_our_containers returns a space-delimited list of
169-
# docker containers that belonged to some part of the Origin deployment.
169+
# containers that belonged to some part of the Origin deployment.
170170
#
171171
# Globals:
172172
# None
@@ -181,7 +181,7 @@ function os::cleanup::internal::list_our_containers() {
181181
readonly -f os::cleanup::internal::list_our_containers
182182

183183
# os::cleanup::internal::list_k8s_containers returns a space-delimited list of
184-
# docker containers that belonged to k8s.
184+
# containers that belonged to k8s.
185185
#
186186
# Globals:
187187
# None
@@ -195,7 +195,7 @@ function os::cleanup::internal::list_k8s_containers() {
195195
readonly -f os::cleanup::internal::list_k8s_containers
196196

197197
# os::cleanup::internal::list_containers returns a space-delimited list of
198-
# docker containers that match a name regex.
198+
# containers that match a name regex.
199199
#
200200
# Globals:
201201
# None

pkg/build/apis/build/types.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ type CustomBuildStrategy struct {
720720
Env []kapi.EnvVar
721721

722722
// ExposeDockerSocket will allow running Docker commands (and build Docker images) from
723-
// inside the Docker container.
723+
// inside the container.
724724
// TODO: Allow admins to enforce 'false' for this option
725725
ExposeDockerSocket bool
726726

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Package strategy contains implementations of core deployment strategies.
22
//
33
// The code in this package will be more verbose with logging given the intended application as
4-
// standalone Docker container CLI support.
4+
// standalone container CLI support.
55
package strategy

staging/src/github.com/openshift/oc/pkg/cli/rollout/rollout.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var (
2727
* Recreate - scales the old replication controller down to zero, then scales the new replication
2828
controller up to full. Use when your application cannot tolerate two versions of code running
2929
at the same time
30-
* Custom - run your own deployment process inside a Docker container using your own scripts.`)
30+
* Custom - run your own deployment process inside a container using your own scripts.`)
3131
)
3232

3333
// NewCmdRollout facilitates kubectl rollout subcommands

test/extended/testdata/bindata.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/util/server/deprecated_openshift/apis/config/types.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ type NodeAuthConfig struct {
285285
// DockerConfig holds Docker related configuration options.
286286
type DockerConfig struct {
287287
// ExecHandlerName is the name of the handler to use for executing
288-
// commands in Docker containers.
288+
// commands in containers.
289289
ExecHandlerName DockerExecHandlerType
290290
// DockerShimSocket is the location of the dockershim socket the kubelet uses.
291291
DockerShimSocket string

0 commit comments

Comments
 (0)