Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable settings.k8s.io/v1alpha1 for 3.6 #14935

Closed
mfojtik opened this issue Jun 28, 2017 · 10 comments
Closed

Disable settings.k8s.io/v1alpha1 for 3.6 #14935

mfojtik opened this issue Jun 28, 2017 · 10 comments

Comments

@mfojtik
Copy link
Contributor

mfojtik commented Jun 28, 2017

Possible solutions:

  • Use RuntimeConfig and parse the strings (nobody wants this ;-)
  • Keep the API enabled and restrict access with policy
  • Other options?
@mfojtik
Copy link
Contributor Author

mfojtik commented Jun 28, 2017

@deads2k lets kick the discussions... i'm fine with 2)

@mfojtik
Copy link
Contributor Author

mfojtik commented Jun 28, 2017

@soltysh we have to figure out what to do with "/apis/batch/v2alpha1" and @DirectXMan12 what to do with "/apis/autoscaling/v2alpha1" :-)

@deads2k
Copy link
Contributor

deads2k commented Jun 28, 2017

@mfojtik I think I may have found a clever-ish spot to wire this in. Mind including a snippet of your extended args?

@mfojtik
Copy link
Contributor Author

mfojtik commented Jun 28, 2017

kubernetesMasterConfig:
  admissionConfig:
    pluginConfig: null
  apiLevels: null
  apiServerArguments:
    runtime-config:
    - apis/settings.k8s.io/v1alpha1=true

@DirectXMan12
Copy link
Contributor

For autoscaling/v2alpha1 is there a reason not to just leave it enabled? All the functionality is available via annotations in v1 due the the round-trip requirements, so it's not like we're actually preventing anything from being used...

@deads2k
Copy link
Contributor

deads2k commented Jun 28, 2017

For autoscaling/v2alpha1 is there a reason not to just leave it enabled? All the functionality is available via annotations in v1 due the the round-trip requirements, so it's not like we're actually preventing anything from being used...

Part of the concern is the possibility of adding other types to the version later on. If we enable it now and have to disable it later, we are not being helpful.

@deads2k
Copy link
Contributor

deads2k commented Jun 28, 2017

@mfojtik alright, I think I found a way to plumb it in here: #14941 if you want to pick that commit and build out from it.

@soltysh
Copy link
Contributor

soltysh commented Jun 29, 2017

@soltysh we have to figure out what to do with "/apis/batch/v2alpha1"

We need to leave it enabled, otherwise we'll break existing clusters. On by default, with option to disable it.

@deads2k
Copy link
Contributor

deads2k commented Jun 30, 2017

@DirectXMan12 is there a backwards compatibility concern or a critical feature in v2alph1 we need?

@DirectXMan12
Copy link
Contributor

@deads2k no, there's no backwards compat concern, since v2alpha1 is new this release. It should be fine to disable it by default and then people can enable it if they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants