Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid char comparison to negative value #32

Open
sam6258 opened this issue May 1, 2018 · 0 comments
Open

Invalid char comparison to negative value #32

sam6258 opened this issue May 1, 2018 · 0 comments

Comments

@sam6258
Copy link

sam6258 commented May 1, 2018

In tests like test_shmem_zero_get.c, there is an invalid comparison between a char and a negative number.

if (dest8[i] != -9) {

Depending on the architecture's implementation of char, the test could fail. According to The C Programming Language, the implementation of char has implementation defined limits. The portable way to do this would be to use signed char.

Test cases failing on Power PC because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant