Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create styles file with reusable styles and measurements #86

Open
AlbertoCasasOrtiz opened this issue Aug 31, 2023 · 2 comments
Open

Create styles file with reusable styles and measurements #86

AlbertoCasasOrtiz opened this issue Aug 31, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@AlbertoCasasOrtiz
Copy link
Collaborator

For example, the AppBar at the top I think is '68px' (In desktop, I am not sure about phones), and I have to hardcode it every time I use it. It would be useful to have a way of making this "importable", like in android where you can have a common styles file for these cases.

This will also allow to have standard values for height/width/displacements in components across the application.

This issue would supose a big change, since we would have to go across all of the files looking for hardcoded values and fix it.

@AlbertoCasasOrtiz AlbertoCasasOrtiz added the enhancement New feature or request label Aug 31, 2023
@aymanhab
Copy link
Member

@AlbertoCasasOrtiz Is this still a valid open issue? Thanks

@AlbertoCasasOrtiz
Copy link
Collaborator Author

I don't think so, as the values that are hardcoded right now are standard (like 68px for top bars), and we introduced the css files for GUI and app versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants