Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new oli-address JSON schema type #472

Open
ryscheng opened this issue Aug 28, 2024 · 0 comments
Open

Create a new oli-address JSON schema type #472

ryscheng opened this issue Aug 28, 2024 · 0 comments
Assignees
Milestone

Comments

@ryscheng
Copy link
Member

For our validation logic, we currently using JSON schema.

I'd suggest creating a new type here:
https://github.com/opensource-observer/oss-directory/tree/main/src/resources/schema

called oli-address.json, which should comply with the OLI definitions. It should look something like they show in their sample data.
https://github.com/openlabelsinitiative/OLI/blob/main/sample_data/op-mainnet_top_100_contracts_by_txcount_2024_07_24.json

Then in the project.json type, let's turn the blockchain section into a union type between blockchain-address and oli-address. This will make it easier for us to migrate addresses incrementally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants