Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pane builder #873

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Conversation

chia7712
Copy link
Contributor

PaneBuilder內部充斥著各種特規格式化,導致PaneBuilder變得肥大且臃腫,這隻PR將各個元件的客製化移動到各個元件的helper,這樣的好處有兩個:

  1. PaneBuilder可以大幅度簡化
  2. 其他pane也可以共用元件的特規化

@chia7712 chia7712 merged commit 0128e47 into opensource4you:main Oct 11, 2022
Haser0305 pushed a commit to Haser0305/astraea that referenced this pull request Oct 13, 2022
@chia7712 chia7712 deleted the refactor_pane_builder branch November 6, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant