Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define SDK summary mode in QuestionnaireConfig #3494

Open
3 tasks
FikriMilano opened this issue Sep 12, 2024 · 2 comments · May be fixed by #3500
Open
3 tasks

Define SDK summary mode in QuestionnaireConfig #3494

FikriMilano opened this issue Sep 12, 2024 · 2 comments · May be fixed by #3500
Assignees

Comments

@FikriMilano
Copy link
Collaborator

FikriMilano commented Sep 12, 2024

Describe the feature request.
Add a new property in the questionnaire config, to allow to use this SDK API

https://github.com/google/android-fhir/blob/6ad0a6751fea3e53d9e2be327ca205cca1112af8/datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt#L347-L351

Additional context

  • In SDK, they call this read-only mode, BUT, we also already have read-only mode, PLUS the read-only mode from SDK looks more like summary mode (I would call it). So, to make it not confusing, we will name this summary mode in OpenSRP 2.
  • Our read-only mode, is a disabled fields that contains text
  • The SDK's read-only mode i.e. summary mode, is purely texts (the fields are changed to texts only)
336119332-a874d74f-91e2-4c0c-950a-f364e333d7ea.webm

Acceptance criteria

  • Should be able to use the read-only mode from SDK

Area path
A list of ordered steps in the app on usage of the feature to support anyone testing it e.g. Code reviewer, QA e.g.

  1. Define a QuestionnaireConfig
  2. Set the SDK summary mode via QuestionnaireConfig to true
  3. Start the app
  4. Open the Questionnaire

Implementation plan (For Engineers)

  • Add a new variable for summary-mode in the QuestionnaireConfig
  • Pass that variable to the QuestionnaireBuilder
@FikriMilano FikriMilano self-assigned this Sep 12, 2024
@FikriMilano FikriMilano changed the title Use SDK read only Use SDK review mode Sep 12, 2024
@FikriMilano FikriMilano changed the title Use SDK review mode Define SDK review mode in QuestionnaireConfig Sep 13, 2024
@FikriMilano FikriMilano changed the title Define SDK review mode in QuestionnaireConfig Define SDK summary mode in QuestionnaireConfig Sep 13, 2024
@FikriMilano FikriMilano linked a pull request Sep 13, 2024 that will close this issue
11 tasks
@ellykits
Copy link
Collaborator

@dubdabasoduba @f-odhiambo Do you have any comment on this? @FikriMilano Has explained why a new property is necessary. It would be great to pick a name that would not cause any confusion.

@FikriMilano
Copy link
Collaborator Author

I had a chat w @f-odhiambo, we've agreed to use "Summary"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants