Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FhirValidator slowing down saving of questionnaires in debug mode #3503

Open
Rkareko opened this issue Sep 13, 2024 · 1 comment · May be fixed by #3509
Open

FhirValidator slowing down saving of questionnaires in debug mode #3503

Rkareko opened this issue Sep 13, 2024 · 1 comment · May be fixed by #3509
Assignees
Labels

Comments

@Rkareko
Copy link
Contributor

Rkareko commented Sep 13, 2024

Describe the feature request.
Enhance FHIR Resource validation to ensure that it does not block saving of resources during extraction on questionnaire submission.

Additional context
Validation of extracted resources kicks in while saving resources on Questionnaire submission in debug mode which seems to slow down the app.
Saving Questionnaires without the validation takes around 1 - 2 seconds. With validation turned on this shoots up to around 30 - 40 seconds.

This was tested on a Samsung A51 with 4GB RAM running android 13.

Acceptance criteria
Saving of questionnaires with validation should take almost the same time as without validation.

Area path
A list of ordered steps in the app on usage of the feature to support anyone testing it e.g. Code reviewer, QA e.g.

  1. Login to the app
  2. Fill and save any questionnaire
  3. Observe the time taken to complete the questionnaire submission

Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
i.e. Describe how you intend to solve the problem

@Rkareko Rkareko changed the title FhirValidator slowing saving of questionnaires in debug mode FhirValidator slowing down saving of questionnaires in debug mode Sep 13, 2024
@pld
Copy link
Member

pld commented Oct 15, 2024

This is a good flag. That's definitely annoying during debug

@LZRS LZRS self-assigned this Oct 17, 2024
@LZRS LZRS linked a pull request Oct 18, 2024 that will close this issue
11 tasks
@ndegwamartin ndegwamartin added this to the FHIR Core Performance milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants