Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port BoringSSL KAT tests for ML-KEM 768 #1045

Closed
andrewkdinh opened this issue Oct 31, 2024 · 2 comments
Closed

Port BoringSSL KAT tests for ML-KEM 768 #1045

andrewkdinh opened this issue Oct 31, 2024 · 2 comments
Assignees
@andrewkdinh

Comments

@andrewkdinh
Copy link

andrewkdinh commented Oct 31, 2024 •
edited
Loading

BoringSSL has KATs for ML-KEM 768 here: https://boringssl.googlesource.com/boringssl/+/refs/heads/master/crypto/mlkem

These include test vectors (inputs and expected outputs) for ML-KEM 768 keygen, encap, and decap

Related to #1015
@andrewkdinh andrewkdinh self-assigned this Oct 31, 2024
@andrewkdinh
Copy link
Author

andrewkdinh commented Oct 31, 2024 •
edited
Loading

It's not useful to implement this at the crypto layer. We will implement this test at the EVP layer: #1013

@andrewkdinh andrewkdinh mentioned this issue Nov 2, 2024
Closed
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 10, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
5bc60c3 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see https://github.com/openssl/private/issues/698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
@andrewkdinh andrewkdinh mentioned this issue Nov 10, 2024
Closed
1 task
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 11, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
d8525e4 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see https://github.com/openssl/private/issues/698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 11, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
989f3f2 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 11, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
85f3a0b 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 11, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
49e7aac 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 11, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
b8e8d90 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 12, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
962aaeb 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
@baentsch baentsch mentioned this issue Nov 12, 2024
Closed
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 12, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
41a51bc 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
@baentsch baentsch mentioned this issue Nov 13, 2024
Closed
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 13, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
0f23e27 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
@andrewkdinh andrewkdinh mentioned this issue Nov 13, 2024
Closed
1 task
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 13, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
ab944a6 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 13, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
b9315ce 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 13, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
54e6661 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl/private#698)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 13, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
0b41144 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl#25885)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 14, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
26ba9a6 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl#25885)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 14, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
dc0067a 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl#25885)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 14, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
51147bf 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl#25885)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 15, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
01c98bb 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl#25885)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 15, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
82fba0d 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl#25885)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
andrewkdinh referenced this issue in andrewkdinh/openssl Nov 20, 2024
@andrewkdinh
Add ML-KEM768 KATs from BoringSSL
8d7bb20 
Add KATs for ML-KEM768 under CCLA from https://boringssl.googlesource.com/boringssl/

These KATs test key generation, encapsulation, and decapsulation for the ML-KEM768 provider.

Relevant notes:
- Added functionality to the ML-KEM provider to export/import. These may not be fully implemented yet (see openssl#25885)
- Exposed some more low-level ML-KEM API's to allow for deterministic encapsulation/key generation
- Actually run 'mlkem_internal_test' with `make test`
- Fixes openssl/private#704
@t8m
Copy link
Member

t8m commented Nov 22, 2024

The PR was Merged

@t8m t8m closed this as completed Nov 22, 2024
@vavroch2010 vavroch2010 transferred this issue from another repository Jan 19, 2025
@vavroch2010 vavroch2010 transferred this issue from another repository Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewkdinh andrewkdinh

Labels
None yet
Projects
Development Board
Status: Done
Project Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t8m @andrewkdinh