Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logout executable data with test-case #104

Merged
merged 4 commits into from
Feb 19, 2019
Merged

Added logout executable data with test-case #104

merged 4 commits into from
Feb 19, 2019

Conversation

gulshanvasnani
Copy link
Contributor

PR contains :-

  1. Executable data for logging out session keys.
  2. Positive test case to verify the event fired on logging out all the sessions.

Fixes :- #75

@gulshanvasnani gulshanvasnani self-assigned this Feb 18, 2019
abhayks1
abhayks1 suggested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯
requested few changes mostly related with refactoring.

lib/helper/TokenHolder.js Show resolved Hide resolved
lib/helper/TokenHolder.js Show resolved Hide resolved
abhayks1
abhayks1 approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhayks1
Copy link
Contributor

@pgev @benjaminbollen Need your inputs also in the PR.

@abhayks1 abhayks1 merged commit a8c423c into OpenST:develop Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhayks1 abhayks1 abhayks1 approved these changes

@pgev pgev pgev approved these changes

@benjaminbollen benjaminbollen Awaiting requested review from benjaminbollen

Assignees

@gulshanvasnani gulshanvasnani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gulshanvasnani @abhayks1 @pgev