Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove license from top of JS files #106

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Remove license from top of JS files #106

merged 1 commit into from
Feb 19, 2019

Conversation

abhayks1
Copy link
Contributor

@abhayks1 abhayks1 commented Feb 18, 2019 •
edited
Loading

We don't need apache license at top of every JS file.
There is single LICENSE file in the repo.
Fixes #105

@abhayks1 abhayks1 self-assigned this Feb 18, 2019
gulshanvasnani
gulshanvasnani approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@gulshanvasnani gulshanvasnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gulshanvasnani gulshanvasnani merged commit aab04f4 into OpenST:develop Feb 19, 2019
@gulshanvasnani gulshanvasnani changed the title Remove license from top of file Remove license from top of JS files Feb 20, 2019
@abhayks1 abhayks1 deleted the remove_js_license branch February 26, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gulshanvasnani gulshanvasnani gulshanvasnani approved these changes

@benjaminbollen benjaminbollen Awaiting requested review from benjaminbollen

@pgev pgev Awaiting requested review from pgev

Assignees

@abhayks1 abhayks1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhayks1 @gulshanvasnani