Docker geth integration and cleanup #108
Conversation
benjaminbollen
left a comment
benjaminbollen
left a comment
There was a problem hiding this comment.
LGTM; I'm outside of this discussion, but at a glance, it looks good.
test/integration/WalletOperations.js
Outdated
| // // wallet3, wallet9 are the owners. | ||
| // wallet1 and wallet2 are the owners. | ||
| it('Should create a user wallet', async function() { | ||
| await auxiliaryWeb3.eth.accounts.wallet.create(1); |
There was a problem hiding this comment.
what s the difference with await auxiliaryWeb3.eth.accounts.wallet.create(3); ?
There was a problem hiding this comment.
@benjaminbollen , Thank you.
Used await auxiliaryWeb3.eth.accounts.wallet.create(3); to create 3 accounts.
Committing the fix.
There was a problem hiding this comment.
I don't understand the system when we seem to call await auxiliaryWeb3.eth.accounts.wallet.create at various places throughout the tests;
this may be less important, and can be addressed later.
There was a problem hiding this comment.
@benjaminbollen
By default, Docker geth provides only 3-accounts.
So, to use more accounts,we need to create it dynamically.
…ad of creating it one-by-one
2 participants
PR contains :-
docker.jsanddocker-compose.ymlto facilitate use of geth docker.helper.jsandWeb3WalletHelper.js.