Docker geth integration and cleanup #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration/WalletOperations.js
Outdated
| it('Should create a user wallet', async function() { | ||
| await auxiliaryWeb3.eth.accounts.wallet.create(1); |
There was a problem hiding this comment.
what s the difference with await auxiliaryWeb3.eth.accounts.wallet.create(3); ?
There was a problem hiding this comment.
@benjaminbollen , Thank you.
Used await auxiliaryWeb3.eth.accounts.wallet.create(3); to create 3 accounts.
Committing the fix.
There was a problem hiding this comment.
I don't understand the system when we seem to call await auxiliaryWeb3.eth.accounts.wallet.create at various places throughout the tests;
this may be less important, and can be addressed later.
There was a problem hiding this comment.
@benjaminbollen
By default, Docker geth provides only 3-accounts.
So, to use more accounts,we need to create it dynamically.
…ad of creating it one-by-one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains :-
docker.jsanddocker-compose.ymlto facilitate use of geth docker.helper.jsandWeb3WalletHelper.js.