Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PricerRule integration test and cleanup #114

Merged
merged 20 commits into from
Feb 25, 2019
Merged

PricerRule integration test and cleanup #114

merged 20 commits into from
Feb 25, 2019

Conversation

abhayks1
Copy link
Contributor

@abhayks1 abhayks1 commented Feb 21, 2019 •
edited
Loading

Below PR covers:

  • PricerRule integration test.
  • Cleanup of integration tests.
  • Update abi/bins.
  • Added missing static methods in Contracts.js.

Fixes #69

@abhayks1
PricerRule integration test in progress
b164550
@abhayks1
PricerRule integration test in progress
178d4a3
@abhayks1
PricerRule integration test in progress
7a01d50
@abhayks1
correct assert to verify priceOracle and acceptanceMargins
499669f
@abhayks1
Removed logging from MockContractsDeployer
4d50f0d
@abhayks1
Set accepted margin integration test fixes
1daa9fb
@abhayks1
tokenrules address not needed in TokenHolder constructor
5410d9b
@abhayks1
Resolved merge conflicts
56f8911
@abhayks1
Integration test changes
3793b0e
@abhayks1
PricerRulePay integration tests
3d9216e
@abhayks1
Removed console logger
5060cb7
@abhayks1
DirectTransfer fixes
82f9f1f
@abhayks1
Refactoring changes
c9e6b5f
@abhayks1
PricerRule Integration tests
48a3534
@abhayks1
Web3 argument not needed in TxSender
2f2d86a
@abhayks1
Web3 argument not needed in TxSender
b090588
@abhayks1
ProxyFactory address doesn't need to be passed in createCompanyWallet…
2071408 
… method
@abhayks1
PricerRule payment integration test cleanup
7a3dbf6
@abhayks1
PricerRule payment integration test and cleanup
1b8c677
@abhayks1
PricerRule payment integration test and cleanup
e38690b
benjaminbollen
benjaminbollen approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; good progression

@benjaminbollen benjaminbollen merged commit 7d74770 into OpenST:develop Feb 25, 2019
@abhayks1 abhayks1 deleted the integration_test_pr_pay branch February 26, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminbollen benjaminbollen benjaminbollen approved these changes

@gulshanvasnani gulshanvasnani Awaiting requested review from gulshanvasnani

@pgev pgev Awaiting requested review from pgev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhayks1 @benjaminbollen