Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PricerRule ABI/BIN with PricerRule:convertPayCurrencyToToken fix #126

Merged
merged 5 commits into from
Mar 4, 2019
Merged

Update PricerRule ABI/BIN with PricerRule:convertPayCurrencyToToken fix #126

merged 5 commits into from
Mar 4, 2019

Conversation

abhayks1
Copy link
Contributor

@abhayks1 abhayks1 commented Mar 4, 2019 •
edited
Loading

PR covers below:

  • Update PricerRule ABI/BIN values.
  • Update test values.
  • Changelog update.
  • Package.json update with new version.

Issue Reference in openst-contract:
OpenST/openst-contracts#164
OpenST/openst-contracts#163

Fixes #125

benjaminbollen and others added 3 commits February 26, 2019 15:11
@benjaminbollen
Merge pull request OpenST#123 from abhayks1/delayed_recovery_hotfix
d9e9dd7 
HotFix: Update domain address field name from "delayedRecoveryModule" to "verifyingContract"
@abhayks1
Merge pull request OpenST#124 from OpenSTFoundation/develop
232ca04 
Update release-0.10 alpha.4 with readme and tests updates
@abhayks1
Update PricerRule abi/bin
af82df4 
Updated test and stub values
@abhayks1 abhayks1 self-assigned this Mar 4, 2019
@abhayks1 abhayks1 changed the title PricerRule ABI/BIN Update Update PricerRule ABI/BIN with PricerRule:convertPayCurrencyToToken fixPricerRule ABI/BIN Update Mar 4, 2019
@abhayks1 abhayks1 changed the title Update PricerRule ABI/BIN with PricerRule:convertPayCurrencyToToken fixPricerRule ABI/BIN Update Update PricerRule ABI/BIN with PricerRule:convertPayCurrencyToToken fix Mar 4, 2019
benjaminbollen
benjaminbollen reviewed Mar 4, 2019
View reviewed changes
test/utils/configReader.js Outdated
sessionKeySpendingLimit: '1000000000000000000000', //1000 ethers
sessionKeyExpirationHeight: '1000000000000000000',
price: '10000000000',
acceptanceMargin: '10000000000',
price: '20000000000000000', // $0.02 = 20*10^16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment seems wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

benjaminbollen
benjaminbollen previously approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

@abhayks1
Copy link
Contributor Author

abhayks1 commented Mar 4, 2019

Requested change done!

benjaminbollen
benjaminbollen approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminbollen benjaminbollen merged commit 0ec8f1d into OpenST:develop Mar 4, 2019
@abhayks1 abhayks1 deleted the pricer_rule_bin_update branch March 5, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminbollen benjaminbollen benjaminbollen approved these changes

@pgev pgev Awaiting requested review from pgev

@gulshanvasnani gulshanvasnani Awaiting requested review from gulshanvasnani

Assignees

@abhayks1 abhayks1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhayks1 @benjaminbollen