Deployment of MultiSig and TokenHolder master copy #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment of master copies and UserWalletFactory
Small cleanup changes of filenames
updated in requires deployContract => DeployContract
abhayks1
changed the title
lib/setup/UserSetup.js
Outdated
| const jsonInterface = abiBinProvider.getABI(MultiSigMasterCopyContractName); | ||
| const bin = abiBinProvider.getBIN(MultiSigMasterCopyContractName); | ||
|
|
||
| let defaultOptions = { |
There was a problem hiding this comment.
We are accepting txOptions in the params.So defaultOptions is not needed.
Also, please remove it from _deployTokenHolderMasterCopyRawTx and _deployUserWalletFactoryRawTx
lib/setup/UserSetup.js
Outdated
| const txObject = oThis._deployMultiSigMasterCopyRawTx(txOptions); | ||
|
|
||
| let params = {}; | ||
| params.contractName = MultiSigMasterCopyContractName; |
There was a problem hiding this comment.
We are constructing params in each deploy method.We can have private method for constructing params object.
What do you think ?
lib/setup/UserSetup.js
Outdated
| return contract.deploy( | ||
| { | ||
| data: bin, | ||
| arguments: args |
There was a problem hiding this comment.
As there are no arguments for constructor of GnosisSafe contract,we can remove arguments: args.
Similar comments for UserWalletFactory and TokenHolder deployment
utils/DeployContract.js
Outdated
| @@ -1,19 +1,21 @@ | |||
| 'use strict'; | |||
|
|
|||
| // TODO Gulshan: Documentation | |||
| // TODO Gulshan: class format | |||
There was a problem hiding this comment.
Ticket created to address it :-
#54
gulshanvasnani
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR covers below tasks: