Test coverage

Author: RoyEJohnson

src/app/components/shell/router-helpers/use-link-handler.ts

@@ -20,12 +20,12 @@ export type TrackedMouseEvent = React.MouseEvent<HTMLAnchorElement> & {
 function handleExternalLink(href: Location['href'], el: HTMLElement) {
     if (el.dataset.local === 'true') {
         // REX books open in the current window; track them
-        window.location.href = href;
+        window.location.assign(href);
     } else {
         const newWindow = window.open(href, '_blank');
 
         if (newWindow === null) {
-            window.location.href = href;
+            window.location.assign(href);
         }
     }
 }
@@ -45,7 +45,7 @@ export default function useLinkHandler() {
             const stripped = linkHelper.stripOpenStaxDomain(path);
 
             if (stripped.startsWith('http')) {
-                window.location.href = stripped;
+                window.location.assign(stripped);
             } else {
                 navigate(stripped, state);
             }

test/src/components/shell/use-link-handler.test.tsx

@@ -60,6 +60,7 @@ describe('use-link-handler', () => {
             <InnerComponent {...props} />
         </MemoryRouter>
     );
+    const saveError = console.error;
 
     afterEach(jest.resetAllMocks);
 
@@ -98,10 +99,29 @@ describe('use-link-handler', () => {
         (useNavigate as jest.Mock).mockReturnValue(navigate);
 
         render(<Component />);
+        console.error = jest.fn();
         await user.click(screen.getByRole('link'));
+        expect(console.error).toHaveBeenCalled();
+        console.error = saveError;
         expect(notPrevented).not.toBeCalled();
         expect(navigate).toBeCalledWith('whatever', {x: 0, y: 0});
     });
+    it('Changes window location when stripping does nothing', async () => {
+        setPortalPrefix('/portal');
+        const el = document.createElement('a');
+
+        jest.spyOn(linkHelper, 'validUrlClick').mockReturnValue(el);
+        jest.spyOn(linkHelper, 'stripOpenStaxDomain').mockReturnValue(
+            'http://whatever'
+        );
+
+        render(<Component />);
+        console.error = jest.fn();
+        await user.click(screen.getByRole('link'));
+        expect(console.error).toHaveBeenCalled();
+        console.error = saveError;
+        expect(notPrevented).not.toBeCalled();
+    });
     it('calls piTracker if available', async () => {
         setPortalPrefix('/portal');
         const navigate = jest.fn();
@@ -141,7 +161,10 @@ describe('use-link-handler', () => {
         (useNavigate as jest.Mock).mockReturnValue(navigate);
 
         render(<Component />);
+        console.error = jest.fn();
         await user.click(screen.getByRole('link'));
+        expect(console.error).toHaveBeenCalled();
+        console.error = saveError;
         expect(notPrevented).not.toBeCalled();
         expect(navigate).not.toBeCalled();
     });
@@ -163,7 +186,10 @@ describe('use-link-handler', () => {
         (useNavigate as jest.Mock).mockReturnValue(navigate);
 
         render(<Component />);
+        console.error = jest.fn();
         await user.click(screen.getByRole('link'));
+        expect(console.error).toHaveBeenCalled();
+        console.error = saveError;
         expect(notPrevented).not.toBeCalled();
         expect(navigate).not.toBeCalled();
     });
@@ -212,5 +238,6 @@ describe('use-link-handler', () => {
         );
         await user.click(screen.getByRole('link'));
         expect(console.error).toBeCalled();
+        console.error = saveError;
     });
 });

test/src/data/all-books.json

@@ -28,7 +28,7 @@
                     "subject_search_description": "This is math search meta"
                 }
             ],
-            "content_warning_text": null,
+            "content_warning_text": "Warning text",
             "cover_url": "https://assets.openstax.org/oscms-dev/media/documents/prealgebra_1.svg"
         },
         {