Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use indoor + opening hours to change icons #106

Open
boothym opened this issue Dec 21, 2022 · 1 comment
Open

Use indoor + opening hours to change icons #106

boothym opened this issue Dec 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@boothym
Copy link

boothym commented Dec 21, 2022

At the moment, it seems like only the access tag is used to change the colour of the AED icons, correct?

That means the map will show (at 21:00) two AEDs tagged as access=yes both with a green icon, even if one has indoor=yes and opening_hours=07:00-17:00, and the other indoor=no + 24/7. You can see that here for example: https://openaedmap.org/#map=16/50.725458/-3.532047 - one of the two green icons here is actually inside a building with restricted opening hours - but you would need to click on each one to find that out.

Capture

I think the more important tags for the map to parse would be the indoor and opening hours values, so that the icon can be changed to indicate that access is sometimes restricted.

Also, access=customers seems to correspond with the yellow icon and "Accessible during work hours" - but that doesn't match the wiki description of that tag: https://wiki.openstreetmap.org/wiki/Tag:access=customers

It would seem a bit strange to have an AED solely for use by customers - it might be located in a shop but if a member of the public needs it outside during opening hours they won't be prevented from using it.

@ttomasz
Copy link
Contributor

ttomasz commented Dec 25, 2022

Thanks, that's an interesting idea. We would need to investigate how such dynamic styling could be done. I'm currently working mostly on backend but maybe someone else will pick it up.

As for definitions of access they were appropriated by Polish community to avoid having to create a completely new tag and the meaning of access tag is slightly different than for most other objects.

For things like tagging attributes of aeds I have no opinion and will implement whatever community reaches consensus on. @wzbartczak can explain the tagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants