Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve combobox dropdown styling to give labels more room and readability #10127

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Improve combobox dropdown styling to give labels more room and readability #10127

merged 3 commits into from
Feb 26, 2024

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Feb 25, 2024 •
edited
Loading

Local test URL

A few screenshots:

  • image
  • image

@tordans
Fields: Break long lines in combo dropdown instead of ellipsis
4644859 
Longer translations keys are not readable with ellipsis and the tooltip only shows the description (or fallback), not the title.

This change makes long use line breaks with small line height to make the whole text visible.
@tordans
Fields: Change html tag from span to div
80adf26 
We use it like a div, so no reason to not use one.
@tordans
Fields: Use table styles for rows to maximize available space
b49fa26 
The flex box solution gave a lot of space to the label. This solution minimizes that space to give more space to the values dropdown.
@tordans tordans requested a review from tyrasd February 25, 2024 10:37
@tyrasd tyrasd added the usability An issue with ease-of-use or design label Feb 25, 2024
@tyrasd tyrasd merged commit ce51b33 into openstreetmap:develop Feb 26, 2024
3 checks passed
@tyrasd tyrasd mentioned this pull request Feb 28, 2024
Merged
bhousel added a commit to facebook/Rapid that referenced this pull request Apr 29, 2024
@bhousel
Improve combobox dropdown styling
d2a7c9b 
re: #1389
re: openstreetmap/iD#10127
re: openstreetmap/iD#10144
@bhousel bhousel mentioned this pull request Apr 29, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees
No one assigned
Labels
usability An issue with ease-of-use or design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tordans @tyrasd