Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't zoom out to z15 when editing a note #10807

Closed
maro-21 opened this issue Feb 22, 2025 · 3 comments · Fixed by #10819
Closed

Don't zoom out to z15 when editing a note #10807

maro-21 opened this issue Feb 22, 2025 · 3 comments · Fixed by #10819
Labels
usability An issue with ease-of-use or design

Comments

@maro-21
Copy link

maro-21 commented Feb 22, 2025

  • Zoom in to z19
  • Paste an address of a note https://osm.org/note/xxxxx
  • The zoom will change to z15, but what for? I can't edit at this zoom. The zoom should not change or change to z19.
@tordans
Copy link
Collaborator

tordans commented Feb 23, 2025

@maro-21 I don't understand your reproduction steps. Could you add some more context and steps?
I wonder if this has to do with zoom changes on osm.org and should be reported there? There where changes to parts of the code that relate to zoom, eg in openstreetmap/openstreetmap-website#5700 and others.

@tordans tordans added the waitfor-info Waiting for more info label Feb 23, 2025
@tyrasd
Copy link
Member

tyrasd commented Feb 24, 2025

I think the issue is when pasting the note id into iD's search bar.

When clicking on any search result, iD normally tries to "fit" the map to show the full feature (i.e. zooming in to a small feature, or zooming out to fit a large one). For point features (nodes and notes), there appear to be hardcoded zoom values: zoom=20 for nodes and zoom=15 for notes. The level 15 is especially annoying, as it zooms one quite far out (so far that iD does not even render the OSM data anymore).

At first glance, I would agree that just preserving the mapper's zoom level is a better solution for notes. For consistency, the behaviour should then be the same also for nodes. For ways/relations it might also make sense in the case where the feature already fully fits the map at the current zoom level.

@tyrasd tyrasd added usability An issue with ease-of-use or design and removed waitfor-info Waiting for more info labels Feb 24, 2025
@maro-21
Copy link
Author

maro-21 commented Feb 24, 2025

I don't understand your reproduction steps. Could you add some more context and steps?

I wrote the exact steps, but you must of course replace "xxxxx" with a note number.

I wonder if this has to do with zoom changes on osm.org and should be reported there? There where changes to parts of the code that relate to zoom, eg in openstreetmap/openstreetmap-website#5700 and others.

It's an old issue and it's been here since notes where added to iD, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants