Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM key appears in value as well #2101

Closed
ypid opened this issue Jan 14, 2014 · 2 comments
Closed

OSM key appears in value as well #2101

ypid opened this issue Jan 14, 2014 · 2 comments

Comments

@ypid
Copy link

ypid commented Jan 14, 2014

Hi

I noticed during clean up of the tag opening_hours, that there are some values which include the key. I saw this already some time ago.

Examples: http://www.openstreetmap.org/node/2617697685/history
http://www.openstreetmap.org/node/2620671611/history
http://www.openstreetmap.org/node/2613486208/history
http://www.openstreetmap.org/node/2616028133/history
http://www.openstreetmap.org/node/614123911/history
http://www.openstreetmap.org/node/418955834/history

There are different users who came up with this. They either used iD 1.3.5 or iD 1.3.4. All changesets are not too old.

PS: Errors have been fixed already (http://www.openstreetmap.org/changeset/20000534) 😄

@jfirebaugh
Copy link
Member

I'm pretty sure this comes from users pasting in examples from http://wiki.openstreetmap.org/wiki/Opening_hours#Examples verbatim. I would recommend removing opening_hours= from that wiki page -- it's clear from the context that they are all values for that key.

@ypid
Copy link
Author

ypid commented Jan 15, 2014

Sounds plausible, I did not think about that. The wiki page uses a template for that and I though it should be clear what the key and value is.

Before removing these in the wiki note that the opening_hours= in front can also come in handy when copying the value and pasting it in JOSM with V respectively Control + Shift + v 😄

Another way to prevent this is to validate opening_hours (#974).

PS: I contacted all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants