Presets depend on tag order, users unable to see real presets

[d1g]

Currently iD depends on tag order. I.e. for object tagged as

building=retail 
shop=mall

iD will display preset for building=retail

shop=mall
building=retail 

iD will display preset for shop=mall

Same with any other tag combination: building=* + real POI tag (shop=pet + building=yes)

Should we fix iD or should we sort tags in database?

[bhousel]

Should we fix iD or should we sort tags in database?

We should probably bump down the priority on building presets so that other tags match first.

[d1g]

@bhousel that's neat. But how exactly "priority" works:

1. It may rank/sort presets when user searches _by term/preset name_ (lets call it "search_rank")
2. it may pick different preset when _user selects some object(s)_ (lets call it "pick_rank")

In this issue we talk about case 2, scenario 1 should be ranked by another tunable variable IMO. Otherwise you will "bump down" priority of "buildings" but they are still important in the regions without buildings.

If I were developing iD, I would consider search_rank as "country-specific" in configs, so users would get more useful suggestions in default presets. "country-specific" tags/presets was a long awaited feature in Russian community. Some tags/presets will never useful in some territory. Other country-specific tags will also benefit from search_rank feature, even it may be hard to implement/maintain correctly.

[d1g]

But actually country-specific settings/ranks may be activated per each instantiation of editor. I.e. openstreetmap.org front-end should spawn iD with configcountryA, configcountryB since this functionality was implemented already.

JOSM able to load config via any loadable URL / command like parameter. URL parameter will make sense for iD.

But case 2/ "pick_rank" is still relevant.

[pnorman]

Should we fix iD or should we sort tags in database?

Tags have no order.

[d1g]

@pnorman good note, yes this statement was imprecise. I meant that tag order is important after we fetch data from db. I shouldn't mention db here.