Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the boundary and then delete the point. #3117

Open
CAIsoul opened this issue May 18, 2016 · 9 comments
Open

Split the boundary and then delete the point. #3117

CAIsoul opened this issue May 18, 2016 · 9 comments
Labels
bug A bug - let's fix this!

Comments

@CAIsoul
Copy link

CAIsoul commented May 18, 2016

In "edit with iD", after I create a polygon, if I click a point and split the boundary into two, followed by deleting this point, the polygon would be broken into polylines even when there are enough polylines left to formulate a polygon.

@bhousel
Copy link
Member

bhousel commented May 18, 2016

Is this what you mean?

split_area

@CAIsoul
Copy link
Author

CAIsoul commented May 19, 2016

Exactly. Is it a bug or it was designed to be this way?

@bhousel
Copy link
Member

bhousel commented May 19, 2016

Looks like a bug to me...

@bhousel bhousel added the bug A bug - let's fix this! label May 19, 2016
@CAIsoul
Copy link
Author

CAIsoul commented May 19, 2016

Agree lol

@slhh
Copy link
Contributor

slhh commented Dec 18, 2016

This is a more general issue, iD does break relations when deleting a connecting vertex. For example deleting a highway junction node breaks routes, even where disconnecting or deleting the ways is prohibited.
This is very bad because users might delete the node in order to workaround the other prevented operations, and they will likely assume, that this is save because it is not prevented.

@slhh
Copy link
Contributor

slhh commented Jan 3, 2017

@bhousel How about renaming this issue in "Delete connecting vertex is breaking relations." The split of an area outline in the origial description is only the method to generate a multipolygon with a connecting vertex at the node which is deleted afterwards.

We don't need to prevent the operation, we can add a new untagged way between the neighboring nodes and add as multipolygon member.

In case of a route we can do similar, but should add a tag identifing the added way as a new feature type like "Broken Route Link". This should be redered in iD indicating it as an error and should generate a warning when trying to upload. But in case it is uploaded by accident, it doesn't seem to be a severe issue for applications, and it simplifies fixing the data issue.

The "Broken Route Link" should preferably have a special behavior dragging it to be coincident with a suitable highway/railway for the route. In this case it should be absorbed by the highway/railway transfering the route membership(s).

We can use a similar approch for some other relation breaking operations like disconnect.

@bhousel If this is acceptable, I will try to make a pull request.

@quincylvania
Copy link
Collaborator

@bhousel What's the preferred behavior here? I assume we'd either disable the delete operation or allow deleting the node but keep the two member ways connected at one of the adjacent nodes.

@bhousel
Copy link
Member

bhousel commented Apr 5, 2019

allow deleting the node but keep the two member ways connected at one of the adjacent nodes.

☝️ I think this is what we want it to do

@quincylvania quincylvania self-assigned this Apr 5, 2019
@slhh
Copy link
Contributor

slhh commented Apr 5, 2019

@quincylvania

but keep the two member ways connected at one of the adjacent nodes.

This seems to be limited to the special case, where at least one of the member ways is untagged, and isn't a member of any other relation.

@quincylvania quincylvania removed their assignment Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

4 participants