Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show specific wiki information for Alley preset #3227

Closed
virgilinojuca opened this issue Jul 6, 2016 · 2 comments
Closed

Show specific wiki information for Alley preset #3227

virgilinojuca opened this issue Jul 6, 2016 · 2 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@virgilinojuca
Copy link

Currently, if you click on the “i” icon in the Alley preset, it shows the same information as in the Service Road preset, which is the text from the highway=service article on the wiki. I think it should display the information from the dedicated article service=alley.

Actually, I suppose the same issue happens in all other presets for tags in the service key, such as service=parking_aisle.

@bhousel bhousel added the preset An issue with an OpenStreetMap preset or tag label Jul 7, 2016
@bhousel
Copy link
Member

bhousel commented Jul 7, 2016

Yes, fields support a reference property to control how the tag documentation lookup works...
Presets should support this too.

@bhousel bhousel added the priority A top priority issue that has a big impact or matter most to new mappers label Mar 22, 2017
@bhousel bhousel closed this as completed in 86c5db8 May 7, 2017
@bhousel
Copy link
Member

bhousel commented May 7, 2017

I just did this. Previously, the preset reference code would just guess by picking the first key in the preset tags. Now we can specify which tag combination is used to fetch documentation. I also went through and updated a lot of presets to have better documentation. This affects just about all presets that use some combination of tags.

Before:

screenshot 2017-05-07 11 54 34

After:

screenshot 2017-05-07 11 54 44

@bhousel bhousel removed the priority A top priority issue that has a big impact or matter most to new mappers label Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants