Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with tag descriptions and wiki redirections #3337

Closed
naoliv opened this issue Aug 9, 2016 · 2 comments
Closed

Problem with tag descriptions and wiki redirections #3337

naoliv opened this issue Aug 9, 2016 · 2 comments

Comments

@naoliv
Copy link

naoliv commented Aug 9, 2016

We were noticing that some key/tags don't have a proper description in iD, when using it in pt_BR
For example, a highway=motorway way is displayed with the key:highway description:

ie, it's displaying the description from https://wiki.openstreetmap.org/wiki/Pt-br:Key:highway instead https://wiki.openstreetmap.org/wiki/Pt-br:Tag:highway%3Dmotorway

And when trying to understand the problem we saw that https://wiki.openstreetmap.org/wiki/Pt-br:Tag:highway%3Dmotorway is actually a redirect to https://wiki.openstreetmap.org/wiki/Pt:Tag:highway%3Dmotorway (as can be see in https://wiki.openstreetmap.org/w/index.php?title=Pt-br:Tag:highway%3Dmotorway&redirect=no)

Could iD somehow detect such redirects and display the final wiki description?

@xendez
Copy link

xendez commented Sep 21, 2016

Confirmed. In fact when is about a key pointing to a redirect page, it shows the message "There is no documentation available for this key" (in Portuguese, of course).

To replicate this: change the language in user preferences to "pt-BR", edit in iD, add a "source" key to any object and click in "i" to get the info. If we change the language in preferences to "pt" it shows the correct message. In the wiki, the page "Pt-br:Key:source" is redirecting to "Pt:Key:source". So iD is not using the redirect.

It would be good to have this issue solved because if we move/redirect more pages from "Pt-br" to "Pt" (sooner or latter we have to do this, should be this way since the beginning because the OSM wiki is "split" by languages and not by countries) the users from Brazil will not see the info.

@bhousel
Copy link
Member

bhousel commented Oct 25, 2016

Nice, looks like you found the linked issue in taginfo 👍 We get results from taginfo that say there is a wiki page, but the result is empty and has no description or image.

I'm not really comfortable with following the redirect and trying to scrape the wiki to get the updated documentation, but I can at least display a message to let the user know that there is documentation for the tag, they just need to click through to the wiki to read it.

Here's what it looks like:

screenshot 2016-10-25 10 58 49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants