Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex navigation improvements #3634

Closed
slhh opened this issue Dec 6, 2016 · 2 comments
Closed

Vertex navigation improvements #3634

slhh opened this issue Dec 6, 2016 · 2 comments

Comments

@slhh
Copy link
Contributor

slhh commented Dec 6, 2016

The current logic determining the related parent has some drawbacks:

  • The normal workflow to select a vertex in iD is to select the way first and the vertex afterwards. This is not required in case of a connecting vertex, but this workflow might still be used. In this case the selected way should be used as the related member, and not more or less ramdomly just one of the connected ways.
  • In case of selecting a connecting vertex directly, iD should not just guess. Instead it should not assign any related parent way.
  • The current logic fails in case a vertex is included in the way two or more times, when counting the start/end vertex of a cyclic way a a single one. ID allows to draw such ways, therefore, they do exist in the database.
  • The first and last vertex of a way are well defined, when the way is selected itself, therefore, these shortcuts should be made available in this case. This simplyfies the required workflow. For even more user convienience, nextVertex and previeousVertex can be made the same as firstVertex and lastVertex respectively.

These changes are already made in my pull request #3631 because I had to rework the code anyway in order to provide an interface for #3603 .

@bhousel
Copy link
Member

bhousel commented Mar 21, 2017

Closing here.. After editing with it this way for a few months, I'm pretty happy with the current behavior of just picking a related parent when there are multiple options. Switching the related parent with \ key is pretty easy to do.

@bhousel bhousel closed this as completed Mar 21, 2017
@slhh
Copy link
Contributor Author

slhh commented Mar 25, 2017

@bhousel
The current behavior is not perfect, but it might be sufficient for your usecases.

The main reason to improve is to allow reusing the related parent and/or navigation logic for other software features like #3604, #3635, and #2206. You wrote in #3926 that you like my suggestion in #2206, which would be just an application of #3635 and the improved related parent logic of this virtex navigation improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants