Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer worldwide search when zoomed far out #3679

Closed
slhh opened this issue Dec 26, 2016 · 4 comments
Closed

Offer worldwide search when zoomed far out #3679

slhh opened this issue Dec 26, 2016 · 4 comments
Labels
good first issue Best for first-time contributors. No experience necessary! usability An issue with ease-of-use or design

Comments

@slhh
Copy link
Contributor

slhh commented Dec 26, 2016

The sidebar is empty when zoomed far out, we should better show a searchbox for the already existing worldwide search instead. We have space to place some instructions here to make OSM-id or coordinate search discoverable.

@bhousel bhousel added the usability An issue with ease-of-use or design label Dec 26, 2016
@bhousel
Copy link
Member

bhousel commented Dec 26, 2016

Good idea!

@bhousel bhousel added the good first issue Best for first-time contributors. No experience necessary! label Mar 26, 2017
@leegenes
Copy link

leegenes commented Aug 9, 2017

Is this still something you all hope to implement? Happy to work on this if someone can point me in the right direction [i.e. toward the right modules].
In the meantime, trying to familiarize myself with the code. Pretty new [almost brand new] to open source world.

@bhousel
Copy link
Member

bhousel commented Aug 25, 2017

Yes @leegenes we'd love help with this!

The code for the "Zoom in to edit" message is here: https://github.com/openstreetmap/iD/blob/master/modules/ui/notice.js

That .notice div is styled to fill and cover up whatever it is inside:

iD/css/80_app.css

Lines 3628 to 3636 in af8779a

.notice {
position: absolute;
top: 0;
bottom: 0;
left: 0;
right: 0;
text-align: center;
background: #fff;
}

So the search is actually behind that "Zoom in to edit" message, but hidden.

I think maybe a better thing to do would be to move the "Zoom in to edit" message on top of the map itself, instead of filling the sidebar.

👇 remove these lines in sidebar.js, and put somewhere else

iD/modules/ui/sidebar.js

Lines 18 to 19 in af8779a

selection
.call(uiNotice(context));

@bhousel
Copy link
Member

bhousel commented Sep 18, 2017

This was done in #4279, thanks @leegenes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants