Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't redo into un-annotated edit states #4006

Closed
bhousel opened this issue May 3, 2017 · 0 comments
Closed

Don't redo into un-annotated edit states #4006

bhousel opened this issue May 3, 2017 · 0 comments
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!

Comments

@bhousel
Copy link
Member

bhousel commented May 3, 2017

The way history.redo() is implemented, it's possible to redo into an un-annotated edit state. This is really bad because the user could perform some temporary edit, then undo out of it, and then redo back into the temporary edit state.

For example, here is me starting to draw an area, then undoing the area, and then redoing back into the state with the temporary area (it's a degenerate area with only 2 nodes).

It's also amusing because the "Redo" button says "Nothing to redo" and appears disabled, but you can still click on it to redo into the temp state anyway.

bad_redo

@bhousel bhousel added the bug-release-blocker An important bug - let's get this fixed in the next release! label May 3, 2017
@bhousel bhousel closed this as completed in 2ebfcd1 May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!
Projects
None yet
Development

No branches or pull requests

1 participant