Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse-right-klick not fully displayed on short-cut-screen #4105

Closed
manfredbrandl opened this issue Jun 12, 2017 · 4 comments
Closed

Mouse-right-klick not fully displayed on short-cut-screen #4105

manfredbrandl opened this issue Jun 12, 2017 · 4 comments
Labels
bug A bug - let's fix this! waitfor Waiting for something

Comments

@manfredbrandl
Copy link
Contributor

image
This can be seen on Chromium Version 57.0.2987.98 Built on 8.7, running on Debian 8.8 (64-bit) and Firefox ESR 45.9.0 on Debian 8.8 (64-bit) and also on Safari on iPad.

@bhousel bhousel added the bug A bug - let's fix this! label Jun 12, 2017
@bhousel
Copy link
Member

bhousel commented Jun 12, 2017

Thanks! Yes I can see that the outline of the mouse icon is not being drawn in black.

@bhousel
Copy link
Member

bhousel commented Jun 12, 2017

It looks like svgo might have removed the black fill when it built the iD-sprite asset on openstreetmap-website. I'll see if I can restore the fill with css, or turn off that rule from the asset pipeline, or just set it to #000001 or something hacky.

maybe this: https://stackoverflow.com/questions/26167106/svgo-killing-000000-fill

@bhousel
Copy link
Member

bhousel commented Jun 12, 2017

I noticed that the fill is missing from the mouse in the tutorial walkthrough also.
Just opened openstreetmap/openstreetmap-website#1563 which hopefully will fix the issue.

missing fill

@bhousel bhousel added the waitfor Waiting for something label Jun 13, 2017
@bhousel
Copy link
Member

bhousel commented Jun 14, 2017

This was fixed in openstreetmap-website. Thanks @tomhughes for help!

svgo was removing the black fill from the mouse symbol, and we fixed it by disabling the removeUnknownsAndDefaults svgo plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! waitfor Waiting for something
Projects
None yet
Development

No branches or pull requests

2 participants