Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with contents of a storage tank #4169

Closed
EwenH opened this issue Jul 20, 2017 · 3 comments
Closed

Issue with contents of a storage tank #4169

EwenH opened this issue Jul 20, 2017 · 3 comments
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag

Comments

@EwenH
Copy link

EwenH commented Jul 20, 2017

Hi,
Hopefully a quick fix with an issue with selecting the contents of a storage tank. Whilst the correct tag "contents" is used in the storage tank default tags, it becomes a singular "content" when adding the tag.

  1. Open ID editor
  2. Create a basic area
  3. From the left hand side search, select "Storage Tank"
  4. Select "water" from the contents
  5. water is added to the list of tags as a value as expected however "contents" has become "content" as the tag << Failure

image

@althio
Copy link
Contributor

althio commented Jul 20, 2017

content is the prefered tag according to wiki.osm.org:Key:content
So content=water is correct.

In iD "Contents" is here not a hard-rule tag in the data.
It is only used as a label in plain english language in the interface.
I guess both "Contents" and "Content" are correct.

@EwenH
Copy link
Author

EwenH commented Jul 20, 2017

Thanks Althio however the validator keepright.at states that "content" should be "contents" and it would be useful however I now see that OSM wiki stats that content is correct. Perhaps just change the label

@bhousel bhousel added preset An issue with an OpenStreetMap preset or tag new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! labels Jul 20, 2017
@bhousel
Copy link
Member

bhousel commented Jul 20, 2017

Sure, we can change the caption from "Contents" to "Content" if that would be clearer.

The field captions do not always exactly match the preset key, but in this case they are both acceptable in English, so we might as well call it what the key is called to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants