Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dog_excrement_bin #4172

Merged
merged 4 commits into from
Jul 22, 2017
Merged

Adding dog_excrement_bin #4172

merged 4 commits into from
Jul 22, 2017

Conversation

JamesKingdom
Copy link
Collaborator

I added a new preset that allows the use of dog excrement bin.
I also added the relative wiki page to pull a definition from.

@bhousel
Copy link
Member

bhousel commented Jul 22, 2017

Can you move the file:
data/presets/presets/amenity/dog_excrement_bin.json
to
data/presets/presets/amenity/waste/dog_excrement.json

We have a naming convention to keep things organized. The former would be for a tag like amenity=dog_excrement_bin, and the latter would be for some special kind of amenity=waste.

Other than that, looks good 👍

@bhousel
Copy link
Member

bhousel commented Jul 22, 2017

Looks good, thank you @JamesKingdom!

@bhousel bhousel merged commit b5dd1ba into openstreetmap:master Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants