Not recognizing highway=services

[naoliv]

I was noticing an user deleting highway=services here.
Trying to understand why, I took a look on iD and saw that it simply says that the object is a "Highway"

Somehow iD is not recognizing higway=services on areas.
Select (or draw) any closed way with highway=services and you should see what is happening.

Example http://www.openstreetmap.org/way/414501953

[bhousel]

I agree iD should add a preset for it..
However the one in your screenshot should have an area=yes. That's the reason why it just looks like a loop of road.

[naoliv]

I guess that area=yes was a workaround for gravitystorm/openstreetmap-carto#137 (which was fixed)

See that it gets properly rendered http://www.openstreetmap.org/way/414501953 without area=yes

Edit: also see that in https://wiki.openstreetmap.org/wiki/Tag:highway%3Dservices it says that it can be used only on nodes and on areas; a closed way should be understood, by default, as an area in this case (without needing to force anything with area=yes)

[bhousel]

The area=yes is needed for any OSM software that doesn't know what a highway=services is (this includes iD, until we add the preset). Because people can invent whatever tags they want, no OSM software has a complete picture of what all the tags are and what area semantics they all imply.

See https://github.com/osmlab/id-area-keys for more on this. It's the "area guessing" code from iD extracted into its own project.

As a rule, you should always add an area=yes for any 'barrier', 'highway', 'footway', 'railway' that you want to be an area, because closed loops of these things are assumed to be lines unless the software knows better.

[naoliv]

While at it, highway=rest_area https://wiki.openstreetmap.org/wiki/Tag:highway%3Drest_area is similar and should get a preset too, if possible.

[JamesKingdom]

There's already a preset for rest area,

[naoliv]

Hum... I see why iD was not recognizing it here.
It should also support highway=rest_area without area=yes (otherwise it will only show Highway too)

highway=rest_area and highway=services are the two exceptions in highway that should be considered an area by default.

[bhousel]

Hmmm.. Looks like we do already have Rest Area and Service Area presets, but they are not recognized without the area=yes. I have to look into our code and see if there is a way to support this.