Adding some more railway presets

[JamesKingdom]

This is to, fix #4193
So far I have added

• Railway Derailer
• Railway Milestone
• Railway Signal
• Railway Switch
• Railway Wash Train wash (6da0719)

Todo:

• Find an appropriate icon for milestone (triangle-stroked)
• Draw railway-signal icon, maybe using something similar to this: Traffic light with two lights instead of 3
• Update wash icon.
• Remove unneeded name from derail and other tags Not possible
• Add a placeholder that tells the user what to input into the milestone field

This could also change the car_wash icon, as currently it is just a car, and looks like a few other presets, this is also the same for railways. So I thought we could maybe add some brushes around the side like shown:

All we need to do is change the car to a train, then we're done.

[manfredbrandl]

Maybe you could use this icon as a starting point, as caution is unique to railways:

[bhousel]

Because there are so many different railway signals around the world, I think I'm just going to use the existing traffic signal icon, but with 2 lights instead of 3. I don't want to overthink it - it just needs to look like a signal but not a highway=traffic_signals.

[Nakaner]

Just my two cents as a railway mapper and OpenRailwayMap contributor:

@bhousel wrote:

Because there are so many different railway signals around the world, I think I'm just going to use the existing traffic signal icon, but with 2 lights instead of 3. I don't want to overthink it - it just needs to look like a signal but not a highway=traffic_signals.

I agree with that. Icons should be simple because they are small. iD is no railway map.

Milestones are white signs with black numbers on them mounted on catenary masts or separate poles in many developed countries nowadays. But JOSM uses a milestone icon, too. Could you please add railway:position=* to the milestone preset? It is used to indicate the distance printed on the milestone/sign.

Using a roadblock as a marker is inappropriate from my point of view but I do not know a better icon. Derailers are small devices.

[bhousel]

Thanks for your feedback @Nakaner!

Milestones are white signs with black numbers on them mounted on catenary masts or separate poles in many developed countries nowadays. But JOSM uses a milestone icon, too. Could you please add railway:position=* to the milestone preset? It is used to indicate the distance printed on the milestone/sign.

Sounds good, we can add this.

Using a roadblock as a marker is inappropriate from my point of view but I do not know a better icon. Derailers are small devices.

Oh the Maki "roadblock" icon I'm thinking of looks like this - it's not a literal road block:

[JamesKingdom]

Could you please add railway:position=* to the milestone preset?

Added:

[Nakaner]

@JamesKingdom Thank you for the quick response. Could the input field show a "only one decimal"? Railway mappers use two tags for the distance, railway:position for the rounded value which is printed in large digits on the sign and railway:position:exact which is the raw value (resolution 1 meter) which is either printed in small digits or is missing at all.

Adding two values might confuse the users. :-/

You could drop the name field because they are nameless and it invites to add name=* which are no names.

[Nakaner]

@bhousel wrote:

Oh the Maki "roadblock" icon I'm thinking of looks like this - it's not a literal road block:

The icon is ok. You could rotate the bar by 45° anti-clockwise if you need a distinction between road blcoks and derailers. If I think that I have a better icon, I will file a pull request. Even the OpenRailwayMap JOSM MapCSS style does not have a derail icon.

[JamesKingdom]

Could the input field show a "only one decimal"?
You could drop the name field

Thanks for the recommendation, unfortunately we can't remove the name, or only show one decimal.

Milestones are white signs with black numbers on them mounted on catenary masts or separate poles in many developed countries nowadays.

We are adding another icon to look more like a milestone, just to confirm what feature they are adding, as a triangle is quite generic and could stand for essentially anything.

Again, it is nice to hear ideas from someone with more experience in the subject, thank you!

[bhousel]

This seems fine @JamesKingdom - can you commit the above change that adds the Milestone Position field, and then you can merge it, and I'll add the icons.

Sorry @Nakaner, as @JamesKingdom said we can not add decimal point formatting to the Milestone field, or remove the Name field. Both of these are reasonable suggestions though, so you can open up new issues for these things if it would help avoid problems with railway mapping.

For now the best thing I can suggest is to make sure that the osm wiki has a really good description and image in the tag template - these things are displayed when the user hits the ℹ️ button next to the field.

[Nakaner]

@bhousel wrote:

Sorry @Nakaner, as @JamesKingdom said we can not add decimal point formatting to the Milestone field, or remove the Name field. Both of these are reasonable suggestions though, so you can open up new issues for these things if it would help avoid problems with railway mapping.

I think you misunderstood me (or I expressed my thoughts not clearly enough). I don't want that the input fields enforce a format. This would be out of scope here. But the text which is displayed in an empty input field could suggest a format, couldn't it?

distance on the milestone rounded to one decimal (i.e. 123.4) or rounded to one decimal (i.e. 123.4)

[JamesKingdom]

I don't want that the input fields enforce a format

Sorry for the misunderstanding, but yes we can certainly add a placeholder.
I shortened it down because it looked pretty messy with all that text in.

[bhousel]

awesome, thanks @JamesKingdom 👍