Don't force the name field onto every object #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesKingdom
added
bluesky
bhousel
reviewed
Aug 1, 2017
modules/ui/preset.js
Outdated
| @@ -40,7 +40,7 @@ export function uiPreset(context) { | |||
| field.show = show; | |||
|
|
|||
| field.shown = function() { | |||
| return field.id === 'name' || field.show || _.some(field.keys, function(key) { return !!tags[key]; }); | |||
| return field.id === '' || field.show || _.some(field.keys, function(key) { return !!tags[key]; }); | |||
There was a problem hiding this comment.
You can just remove the field.id === '' clause. No field will be like this.
|
This looks pretty good. I like the idea of not giving the I fixed a small thing: now it is possible for there to be no fields in the "all fields" section, and that was causing this empty div to look weird:
Added a rule so that div will not appear if empty:
|
|
Merging now, so I can get a start on #3914 today.. Per chat, @JamesKingdom will add most of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4200
How?
Currently all presets force a name field onto them.
field=nameadded onto it, only a few will not.But what if that object really has a name?
The option will be available in the "Add field" box at the bottom, and work just like the other options, so that a name can be added if needed.
This will then add back a name field:
