Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for intermittent streams #4337

Closed
valleyofdawn opened this issue Sep 10, 2017 · 9 comments
Closed

Add preset for intermittent streams #4337

valleyofdawn opened this issue Sep 10, 2017 · 9 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@valleyofdawn
Copy link

valleyofdawn commented Sep 10, 2017

In arid countries most of the waterways we trace are intermittent streams.
We manually add the intermittent=yes tag.
Would be useful if a separate entry for these entities existed under water in iD.
It could be called a gully, a wadi, an arroyo, as the names change geographically.

@bhousel bhousel changed the title Add shortcut for intermittent streams Add preset for intermittent streams Sep 10, 2017
@bhousel bhousel added preset An issue with an OpenStreetMap preset or tag good first issue Best for first-time contributors. No experience necessary! labels Sep 10, 2017
@bhousel
Copy link
Member

bhousel commented Sep 10, 2017

Sounds good to me.. We could add an "Intermittent Stream" preset, with all those other words in the search terms.

@boothym
Copy link
Contributor

boothym commented Sep 10, 2017

Or what about an intermittent checkbox field (like oneway) added to the waterway presets?

@bhousel
Copy link
Member

bhousel commented Sep 10, 2017

Or what about an intermittent checkbox field (like oneway) added to the waterway presets?

That would work too, then we would want to add those search terms to whatever waterway preset might use the field. I guess we would only add it to stream? I'm assuming it's probably not really used on river, canal, drain.

@valleyofdawn
Copy link
Author

The checkbox would also be very relevant to reservoirs and ponds, but I like the preset solution better.

@valleyofdawn
Copy link
Author

Also "wash" and "gulch" are sometimes used to describe such dry streams.

@bhousel
Copy link
Member

bhousel commented Sep 10, 2017

The checkbox would also be very relevant to reservoirs and ponds, but I like the preset solution better.

Ok, in that case then I agree a checkbox makes more sense. 👍

@slhh
Copy link
Contributor

slhh commented Sep 10, 2017

Streams and ditches seem to be the most frequent intermittent waterways. Drains and reservoirs are quite likely to be intermittent too.

Rivers are less likely, but more than 25000 intermittent ones do exist in the database (2.5% of all rivers).
Aproxiamtely 1% of ponds and lakes are tagged with intermittent=yes, and we can assume that such a secondary tag is used less often than it should be.

We do have 1000 intermittent canals in the database, but most might be mistagged drains.

In addition to the more probable features the intermittent field should be shown for all water/waterway features where the tag is present.

I don't like the preset solution, because it can led to tag a waterway as a stream, just because it is an intermittent waterway.

@valleyofdawn
Copy link
Author

Fair enough.
The reason I like the preset better is that I often trace tens of those in one changeset and having "Gully" at the top of the list would save me some clicking. Maybe both solutions can be implemented together?

@bhousel
Copy link
Member

bhousel commented Sep 11, 2017

The reason I like the preset better is that I often trace tens of those in one changeset and having "Gully" at the top of the list would save me some clicking. Maybe both solutions can be implemented together?

Yes, that's what I did - there's now a checkbox that's added to all the waterway presets, along with a few others like "spring", "pond", "waterfall", etc. And also a preset for "Intermittent Stream" which has the box checked already.

screenshot 2017-09-11 14 15 39

closed in fec27a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

4 participants