Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving changes to very large relations takes a very long time #4361

Closed
bborkmiller opened this issue Sep 20, 2017 · 5 comments
Closed

Saving changes to very large relations takes a very long time #4361

bborkmiller opened this issue Sep 20, 2017 · 5 comments
Labels
performance Optimizing for speed and efficiency

Comments

@bborkmiller
Copy link

I think iD might have an issue editing very large relations. I made a minor edit to the Lake Huron relation and it took Chrome a very long time (> 1 hour) to finish saving the changes (in fact, it's still chugging away).* While it was in the process of saving Chrome's memory usage for that tab was very high:

image

Chrome version 60.0.3112.113 on Windows, iD version 2.4.1

*Once my changeset finishes saving, I'll link to it here. I had a similar problem yesterday with this changeset but the one I'm saving today is much simpler and it still is taking a long time to save.

@bborkmiller bborkmiller changed the title Saving changes to very large relations takes a very large time Saving changes to very large relations takes a very long time Sep 20, 2017
@bhousel
Copy link
Member

bhousel commented Sep 20, 2017

Yes, I'm not surprised.. I think this is #3056

@bhousel bhousel added the performance Optimizing for speed and efficiency label Sep 20, 2017
@bborkmiller
Copy link
Author

Makes sense! FYI, it looks like my changeset from yesterday took about four hours to finish saving. I'm a little concerned (maybe without justification) that a conflict will crop up while iD is running its checks.

@bborkmiller
Copy link
Author

FWIW, my other changeset did successfully save, eventually. Here's a link, in case it helps to have a cleaner example.

Thanks for all your work on iD! I use it just about every day.

@bhousel
Copy link
Member

bhousel commented Nov 14, 2017

Thanks for all your work on iD! I use it just about every day.

Thanks for the kind words! ...

@bhousel
Copy link
Member

bhousel commented Nov 14, 2017

closing as duplicate of #3056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Optimizing for speed and efficiency
Projects
None yet
Development

No branches or pull requests

2 participants