Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking “Zoom in to edit” crashes Firefox #4421

Open
1ec5 opened this issue Oct 9, 2017 · 8 comments
Open

Clicking “Zoom in to edit” crashes Firefox #4421

1ec5 opened this issue Oct 9, 2017 · 8 comments
Labels
bug-browser-specific A bug that only appears in certain browsers

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Oct 9, 2017

If you start out at z0 and click “Zoom in to edit”, Firefox crashes. The workaround is to use the scroll wheel to gently zoom in level by level until editing is enabled.

Tracking upstream in Bugzilla bug 1,406,982. I’ve observed this crash for months but apparently neglected to file an issue about it until now.

@bhousel bhousel added bug-browser-specific A bug that only appears in certain browsers waitfor-upstream Waiting for something in an upstream project labels Oct 9, 2017
@boothym
Copy link
Contributor

boothym commented Oct 11, 2017

Firefox/Win10 here, no problems zooming right out and clicking zoom in to edit.

@1ec5
Copy link
Collaborator Author

1ec5 commented Oct 11, 2017

Ah, in case it matters, I’m on a Mac; haven’t tried on Windows.

@bhousel
Copy link
Member

bhousel commented Nov 15, 2017

This still happens in Firefox 57 😢
I'll see if I can put in a workaround. Since mousewheeling works, maybe I can add a zoom transition to ease the user in.

@bhousel
Copy link
Member

bhousel commented Nov 15, 2017

Eased zoom looks nicer and doesn't crash in Firefox 🤷‍♂️ 👍

@bhousel bhousel removed the waitfor-upstream Waiting for something in an upstream project label Nov 15, 2017
@1ec5
Copy link
Collaborator Author

1ec5 commented Nov 16, 2017

I just got this crash in Firefox 56 zooming in from z0 on master (add1bac). According to the Bugzilla issue and crash report, the underlying issue is an out-of-memory error caused by scaling up the map too much and too rapidly.

@1ec5 1ec5 reopened this Nov 16, 2017
@bhousel
Copy link
Member

bhousel commented Nov 16, 2017

Thanks for checking - I agree we can leave this open and I'll see if there is a workaround we can add.

@quincylvania
Copy link
Collaborator

@1ec5 Have you seen this lately? I've been using iD in Firefox routinely on a Mac and never encountered a crash.

@Dimitar5555
Copy link
Contributor

It seems like this bug is fixed since the starting zoom level is 2 and there is no way to go to zoom level 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-browser-specific A bug that only appears in certain browsers
Projects
None yet
Development

No branches or pull requests

5 participants