-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the features api parameter which enables the list of features #4439
add the features api parameter which enables the list of features #4439
Conversation
Thanks @ferdibiflator - this looks really good! I'll check it out some more tomorrow, in the meantime can you also update the API.md doc "url parameters" sections to include the new option? |
@bhousel I found a problem with id = iD.Context()
.assetPath('dist/');
id.features().disable('boundaries');
id.ui()(document.getElementById('id-container'), function() { I suggest to disable this one in accordance with some logic within the |
Hello @bhousel. Any news? |
This looks good, and I'll merge it any day now, thanks for being patient. |
Hey @ferdibiflator I tried it out and I think I'm going to change it so that the url querystring contains the hidden features, instead of the shown features.. It's just a little less wordy that way. What you did is great, so I'm just going to merge as-is and make the change in a followup commit 👍 |
btw @ferdibiflator re this:
I worked around this in 30ff683 by changing the code in I mostly consider |
Fixes #4393
features
api parameter is added for enabling the features in the list (,
is the splitter)Also the hash is being updated when the user toggles features