Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using uiDisclosure messes up the url #4570

Closed
bhousel opened this issue Nov 28, 2017 · 0 comments
Closed

Using uiDisclosure messes up the url #4570

bhousel opened this issue Nov 28, 2017 · 0 comments
Labels
bug A bug - let's fix this!

Comments

@bhousel
Copy link
Member

bhousel commented Nov 28, 2017

This happens because the uiDisclosure is uses an <a> and we need to preventDefault the click on it.

disclosure_bug
@bhousel bhousel added bug A bug - let's fix this! wip Work in progress labels Nov 28, 2017
@bhousel bhousel mentioned this issue Nov 29, 2017
Merged
6 tasks
@bhousel bhousel closed this as completed in 5a9749c Jan 3, 2018
@bhousel bhousel removed the wip Work in progress label Jan 3, 2018
@bhousel bhousel mentioned this issue Jan 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug - let's fix this!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel