Surveillance camera with direction only visible in wireframe mode

[1ec5]

A standalone Surveillance Camera point tagged with camera:direction is completely invisible on the map. Selecting it doesn’t make it visible, although the feature editor does behave normally. Enabling wireframe mode makes the point visible.

Reproduced in be5929d. This regression was likely introduced in #4602.

[bhousel]

Thanks for reporting - I'm having trouble reproducing this (have tried Chrome, Safari, and Firefox).
Can you point me at a nodeid that is showing up invisible?

[1ec5]

I’m seeing this in both Firefox 56.0b12 and Safari 11 on macOS 10.12.6. Unfortunately, I don’t know of any actual surveillance cameras to save into the live database, but the issue seems to affect any point so tagged; it isn’t specific to a particular existing POI.

[1ec5]

Not sure if it means anything, but when the point icon goes away, the group for the icon also disappears from the layer-points-points group.

[1ec5]

Apparently this issue only reproduces at exactly z18, but not at z17.9 or z18.1. A directional node won’t render as a point or vertex at z18:

iD/modules/svg/points.js

Lines 75 to 79 in be5929d

	// points with a direction will render as vertices at higher zooms
	function renderAsPoint(entity) {
	return entity.geometry(graph) === 'point' &&
	!(zoom >= 18 && entity.directions(graph, projection).length);
	}

iD/modules/svg/vertices.js

Lines 258 to 266 in be5929d

	// Points can also render as vertices:
	// 1. in wireframe mode or
	// 2. at higher zooms if they have a direction
	function renderAsVertex(entity, graph, wireframe, zoom) {
	var geometry = entity.geometry(graph);
	return geometry === 'vertex' || (geometry === 'point' && (
	wireframe || (zoom > 18 && entity.directions(graph, projection).length)
	));
	}