You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our current replaceMember behavior removes duplicates from the relation list - I think this is wrong in the context of a Public Transport route relation. We call this function numerous places in the iD code when working with relations.
Here is an example of a route that might break if we call replaceMember on it:
Route: A - B - C - B - D
// 'B' is duplicate but should not be removed!r=iD.osmRelation({members: [{id: 'A',role: 'forward',type: 'way'},{id: 'B',role: 'forward',type: 'way'},{id: 'C',role: 'forward',type: 'way'},{id: 'B',role: 'forward',type: 'way'},{id: 'D',role: 'forward',type: 'way'}]});
Also related to #4589
Our current
replaceMember
behavior removes duplicates from the relation list - I think this is wrong in the context of a Public Transport route relation. We call this function numerous places in the iD code when working with relations.iD/test/spec/osm/relation.js
Lines 274 to 279 in fdf1fa4
Here is an example of a route that might break if we call
replaceMember
on it:Route: A - B - C - B - D
more reading:
The text was updated successfully, but these errors were encountered: