Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addr:unit not used in Switzerland #4729

Closed
Marc-marc-marc opened this issue Jan 22, 2018 · 2 comments
Closed

addr:unit not used in Switzerland #4729

Marc-marc-marc opened this issue Jan 22, 2018 · 2 comments
Labels
good first issue Best for first-time contributors. No experience necessary!

Comments

@Marc-marc-marc
Copy link
Contributor

like #4667
addr:unit is nearly never used in addressing for Switzerland
5 addr:unit (seems all wrong) / 900 000 addr:housenumber
it should be hidden until a housenumber is filled or hidden if empty like for France.
@bhousel bhousel added the good first issue Best for first-time contributors. No experience necessary! label Jan 22, 2018
@ENT8R
Copy link
Contributor

ENT8R commented Jan 23, 2018

Are you sure that it is actually shown for Switzerland?
In the code is no unit value set for the country codes at, ch, de, si:

iD/data/address-formats.json

Line 27 in 6570365

"countryCodes": ["at", "ch", "de", "si"],

@Marc-marc-marc
Copy link
Contributor Author

you're right, I noticed the problem before the update that just happened.
addr:unit doesn't show anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Best for first-time contributors. No experience necessary!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bhousel @ENT8R @Marc-marc-marc