Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow seeing the whole Custom Background URL one is entering #4802

Closed
jidanni opened this issue Feb 14, 2018 · 7 comments
Closed

Allow seeing the whole Custom Background URL one is entering #4802

jidanni opened this issue Feb 14, 2018 · 7 comments
Assignees
Labels
usability An issue with ease-of-use or design

Comments

@jidanni
Copy link
Contributor

jidanni commented Feb 14, 2018

Allow seeing the whole Custom Background URL one is entering, like JOSM.
JOSM has an entire huge box, but iD has just this tiny textbox which is never enough.
gm
One needs to see the whole thing one entered, so one can be totally sure. Even if one can poke around the various parts.
Never mind my blue highlighting in the image.

@bhousel
Copy link
Member

bhousel commented Feb 14, 2018

What does it look like in JOSM?

@jidanni
Copy link
Contributor Author

jidanni commented Feb 14, 2018

@bhousel
Copy link
Member

bhousel commented Feb 14, 2018

If we change this, we'd need to replace this window.prompt call with a new modal dialog box that can show a textfield. (window.prompt can only do one line, and we don't have any options to customize it)

iD/modules/ui/background.js

Lines 106 to 109 in 73f78c3

var template = window.prompt(
t('background.custom_prompt', { example: example }),
_customSource.template() || example
);

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Feb 14, 2018
@bhousel bhousel changed the title Allow seeing the whole Custom Background URL one is entering, like JOSM Allow seeing the whole Custom Background URL one is entering Feb 14, 2018
@manfredbrandl
Copy link
Contributor

manfredbrandl commented Feb 15, 2018

I would like iD to remember the custom URL templates for me.

@bhousel
Copy link
Member

bhousel commented Jun 29, 2018

tagging @vershwal - this is kind of the same as #4806

@bhousel bhousel added usability An issue with ease-of-use or design and removed considering Not Actionable - still considering if this is something we want labels Jun 29, 2018
@bhousel
Copy link
Member

bhousel commented Jun 29, 2018

More context - this issue will be closed if we replace the window.alert box with a modal screen. We'll be able to replace the single line input with an actual textarea that shows multiple lines.

@bhousel
Copy link
Member

bhousel commented Aug 11, 2018

This was done in #5207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

4 participants