Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more wms / wmts imagery #4828

Open
grischard opened this issue Feb 21, 2018 · 11 comments
Open

Support more wms / wmts imagery #4828

grischard opened this issue Feb 21, 2018 · 11 comments
Labels
bluesky Bluesky issues are extra challenging - this might take a while or be impossible new-feature A new feature for iD

Comments

@grischard
Copy link
Contributor

Once #4814 gets merged, we should also support ELI sources of the wms_endpoint type like this one. The URLs are for getCapabilities requests on a WMS, which return a list of layers and sublayers.

In the iD interface, they could be shown as a folder, maybe with the icon.

@bhousel bhousel added new-feature A new feature for iD bluesky Bluesky issues are extra challenging - this might take a while or be impossible labels Feb 21, 2018
@bhousel
Copy link
Member

bhousel commented Feb 21, 2018

Cool! I labelled as bluesky, but it #4633 might already contain a lot of the code needed. It's on my list of things to get to..

@grischard
Copy link
Contributor Author

If we're doing this, we should also support WMTS sources. https://josm.openstreetmap.de/wiki/ImageryCompare shows that JOSM has about 100 that ELI doesn't have.

@bhousel
Copy link
Member

bhousel commented Dec 4, 2018

has about 100 that ELI doesn't have.

Be careful comparing the datasets on count alone. Lots of the imagery in their in their index is stuff like people's hobby projects, like maps of scotland from the 1800s or whatever.

We also host a proxy on openstreetmap.us that may be able to proxy wmts? I don't know but @jonahadkins and @iandees would be able to say.

@grischard
Copy link
Contributor Author

Indeed, it's the wet finger approach, but those wmts entries tend to be catalogs of open data.

Yeah, mapproxy would be one way of doing it, but then we have no idea when another layer is added to the wmts. In general, it would be good to support those useful catalogs.

@grischard grischard changed the title Support wms_endpoint imagery Support wms_endpoint and wmts imagery Nov 20, 2019
@grischard grischard changed the title Support wms_endpoint and wmts imagery Support wms_endpoint imagery Nov 20, 2019
@bhousel bhousel changed the title Support wms_endpoint imagery Support more wms / wmts imagery Nov 20, 2019
@matkoniecz
Copy link
Contributor

matkoniecz commented Aug 11, 2020

Be careful comparing the datasets on count alone. Lots of the imagery in their in their index is stuff like people's hobby projects, like maps of scotland from the 1800s or whatever.

To be more specific. Main imagery for Poland is no longer available as WMS, WMTS works ( Geoportal2 WMS is showing as white tiles 99,99% percent of time for some reason osmlab/editor-layer-index#877 ).

As result primary and best imagery for Poland is inaccessible in iD/Vespucci but remains available in JOSM because it supports WMTS.

2023 edit: this is now fixed

@CharlesMaZ
Copy link

We have very good aerial photos from the geoportal available in Poland. Unfortunately, WMS works slowly and even ceases to be supported. Please support WMTS in iD, because it will enable easier and faster editing and will eliminate problems with using WMS.

@rmikke
Copy link

rmikke commented Aug 11, 2020

👍

@swiss-knight
Copy link

Follow up on the new Open Government Data provided by our Federal Office of Topography and this article https://sosm.ch/welcome-swisstopo/ I would be glad to use OGC WMTS services in iD !

Because WMS is... well, not super friendly imho. And the TSM scheme is not available for the data I'd like to use as a custom background.

I was also totally successful using some of these WMTS service in JOSM in no time. ;-)

@cicku
Copy link
Contributor

cicku commented Sep 10, 2021

source.projection = 'EPSG:3857'; // guess

Please consider improving this logic here (adding support of reprojection/CRS:84). Currently my state has several sources without EPSG:3857 support at anytime, but they support CRS:84. The real "EPSG" being used is 2272, a state-specific NAD83 system.

@Artoria2e5
Copy link

Artoria2e5 commented Apr 30, 2023

@cicku it looks like there's also some 4326 projection code that isn't being made available through the url-only "custom" interface. They may need a new selection box to enter a user-defined source.projection.

there is some swapping code on 4326 from #7557, so if that selection gets added, CRS:84 support should be basically automatic.

@grischard
Copy link
Contributor Author

@tyrasd could you please put this on your radar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluesky Bluesky issues are extra challenging - this might take a while or be impossible new-feature A new feature for iD
Projects
None yet
Development

No branches or pull requests

8 participants