Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node 4 / npm 2 #4853

Closed
greenkeeper bot opened this issue Mar 7, 2018 · 4 comments
Closed

Drop support for node 4 / npm 2 #4853

greenkeeper bot opened this issue Mar 7, 2018 · 4 comments
Labels
chore Improvements to the iD development experience or codebase

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Mar 7, 2018

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 0.56.5 of rollup was just published.

Branch Build failing 🚨
Dependency rollup
Current Version 0.56.4
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 22 commits.

There are 22 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Mar 7, 2018

After pinning to 0.56.4 your tests are passing again. Downgrade this dependency 📌.

@bhousel
Copy link
Member

bhousel commented Mar 7, 2018

This seems spurious. I reviewed the travis log for this build, and it shows an error with a missing module that it couldn't find.

I tried a local build using:

$ node --version
v4.8.4
$ npm --version
2.15.11

...and got a similar error but for a different module, which was resolved after running npm install a second time. (see npm/npm#10727)..

I'm thinking of just dropping support for node4/npm2, since it's going away soon anyway and our dependencies are starting to break in weird ways that I don't really have time to track down.

@bhousel bhousel changed the title An in-range update of rollup is breaking the build 🚨 Drop support for node 4 / npm 2 Mar 8, 2018
@bhousel bhousel added chore Improvements to the iD development experience or codebase and removed chore-greenkeeper labels Mar 8, 2018
@bhousel
Copy link
Member

bhousel commented Mar 8, 2018

We'll do this next minor release (iD v2.8.0)

@bhousel bhousel added this to the v2.8 milestone Mar 8, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Mar 17, 2018

Version 0.57.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Commits

The new version differs by 78 commits.

There are 78 commits in total.

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements to the iD development experience or codebase
Projects
None yet
Development

No branches or pull requests

1 participant