-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions should be able to request additional data #4890
Comments
I think what we really want to do is just have the We can't schedule them asynchronously because the graph could change before they get a chance to run. |
In some cases this might be sufficient, but in general this seems to be quite unfriendly to the user.
My idea was to keep it still sychronized with the user interface. That means, in the hopefully rare cases requiring additional data, the UI would be temporarily not accepting any user input, which results in not changing the graph. ID needs to show an indicator of being busy like an hourglass. This is a little nasty, but not being able to use the intended operation is much worse. |
Done in #6140 If the user clicks again after the data is downloaded, they will see the operation as available. |
Some existing and potential actions need more data than available in the graph to be executed safely or to be executed at all.
Actions should be able to check for missing data, issue the database requests, and reschedule themselves on the last callback.
Maybe, iD needs to leave mode select and enter a new wait mode.
Related issues: e.g. #2248, #4876
The text was updated successfully, but these errors were encountered: