Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pencil icon. #4908

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Added pencil icon. #4908

merged 3 commits into from
Mar 23, 2018

Conversation

vershwal
Copy link
Collaborator

@vershwal vershwal commented Mar 17, 2018

Fixes #4798.
Hey @bhousel!
I have added a new pencil icon and changed the icon for 'Edit custom background' from magnifying glass to pencil icon.
It was also mentioned in the issue that the text should say "Edit custom background URL template" and not "Edit custom background" but it was not discussed, so should I change the text too?

@bhousel
Copy link
Member

bhousel commented Mar 19, 2018

Before After
screenshot 2018-03-19 18 23 54 screenshot 2018-03-19 18 24 07

Thanks @vershwal
It looks ok - can you adjust the width of the button so that it looks a bit more centered?

Also, did you draw it or find it somewhere? Just want to make sure it is license compatible with this project. If there is any doubt, I can just redraw the icon from scratch - this is fine too.

@vershwal
Copy link
Collaborator Author

Hey @bhousel!!
I will adjust the width that is fine. But I didn't draw it from scratch. I found it here and then adjusted the code to fit it in our iD-sprite.src.svg. I was not aware of the licence part. Please check that. And if there is any doubt, I would love to draw it myself. I would have to learn it as this is my first time with SVG drawing, but that would be fun.

@vershwal
Copy link
Collaborator Author

Hey @bhousel!! I have modified the icon. I am sure that this one will be license compatible with this project.
Please check.
Before :
screen shot 2018-03-23 at 11 22 55 pm
After:
screen shot 2018-03-23 at 11 34 14 pm

@bhousel
Copy link
Member

bhousel commented Mar 23, 2018

The new icon looks really good ❤️ Thank you!

@bhousel bhousel merged commit df5383c into openstreetmap:master Mar 23, 2018
@vershwal
Copy link
Collaborator Author

Thank you @bhousel!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants