Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added monastary #4936

Merged
merged 3 commits into from
Mar 24, 2018
Merged

added monastary #4936

merged 3 commits into from
Mar 24, 2018

Conversation

Xavier-J-Ortiz
Copy link
Contributor

@Xavier-J-Ortiz Xavier-J-Ortiz commented Mar 24, 2018 •
edited
Loading

Refs:#4932

@Xavier-J-Ortiz
Copy link
Contributor Author

@bhousel I left the icon as place-of-worship since I'm not sure if a monastery-groundsicon exists.

Let me know if this looks good.

bhousel
bhousel suggested changes Mar 24, 2018
View reviewed changes
data/presets/presets.json Outdated
"denomination",
"address",
"building_area",
"service_times"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they do services at monasteries. Can you remove this field? Everything else about this looks great 👍

@Xavier-J-Ortiz
Copy link
Contributor Author

Oh right!

Changed, committed, and pushed.

@Xavier-J-Ortiz Xavier-J-Ortiz force-pushed the add_amenity_monestary branch from 5f4f551 to 3406b8d Compare March 24, 2018 16:57
@Xavier-J-Ortiz Xavier-J-Ortiz force-pushed the add_amenity_monestary branch from 3406b8d to 1b01b2e Compare March 24, 2018 16:58
@bhousel
Copy link
Member

bhousel commented Mar 24, 2018

Thanks @Xavier-J-Ortiz !

@bhousel bhousel merged commit 9e02cde into openstreetmap:master Mar 24, 2018
@alexander-ii
Copy link

alexander-ii commented Mar 24, 2018 •
edited
Loading

It needs to be mentioned, that there is possibly a mistake. This PR introduces a new tag amenity=monastery_grounds. Which is absent in wiki and taginfo as well.

Please, fix it.

@bhousel bhousel mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel bhousel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xavier-J-Ortiz @bhousel @alexander-ii