Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep already existing nodes when connecting two nodes #4974

Closed
hikemaniac opened this issue Apr 9, 2018 · 3 comments
Closed

Keep already existing nodes when connecting two nodes #4974

hikemaniac opened this issue Apr 9, 2018 · 3 comments

Comments

@hikemaniac
Copy link
Contributor

In many of my changesets I connect newly created areas with previously existing ones. Unfortunately iD will replace a lot of older nodes with my newly created ones. This results in mass deletion and weird error messages from the editor itself (You have deleted x objects...) even though the user is pretty convinced he didn't do such a change. The older nodes are only replaced when a new node is created, but isn't yet connected to any area. When it is then dragged and connected, the older node gets replaced. Would it be possible to keep already existing nodes when connecting two of them?

@bhousel
Copy link
Member

bhousel commented Apr 9, 2018

This is probably the same as #4674
I can change actionConnect to prefer an existing node to keep as the survivor.

var last = nodeIds[nodeIds.length - 1];
var survivor = graph.entity(last);

@hikemaniac
Copy link
Contributor Author

You are right, the situation is different, but the core issue is the same. I'll close it if you want to.

@bhousel
Copy link
Member

bhousel commented Apr 9, 2018

Nah ok to leave open, I'm fixing it now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants