Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset for amenity=telephone lacks covered=booth #5088

Closed
eehpcm opened this issue Jun 17, 2018 · 4 comments
Closed

Preset for amenity=telephone lacks covered=booth #5088

eehpcm opened this issue Jun 17, 2018 · 4 comments

Comments

@eehpcm
Copy link

eehpcm commented Jun 17, 2018

The preset for amenity=telephone offers covered=yes and covered=no. Most public telephones in the UK (neglecting the emergency phones along motorways) are in booths.

Depending upon which wiki page you look at, either covered is not applicable to telephones or booth is one of three possibilities (the others being yes and no).

In the UK, possibly also in other countries, it would make life easier if covered were one of yes/no/booth instead of just yes/no.

@bhousel
Copy link
Member

bhousel commented Jun 17, 2018

Oh yeah interesting.. I've always thought of covered=* as being for highways going under a building part (to avoid triggering building/highway validation)

But I can see here it's being suggested as a way to map phone booths
screenshot 2018-06-17 11 26 02

Here is two better options:

  1. (I prefer this choice) Drop the tag covered=booth completely. It doesn't fit in with the more established use of covered=yes/no and it's not needed if we have a tag booth=*, which people are using 4000+ uses. iD could easily add a booth=* field to the telephone preset, and that could just be the tag.

  2. If we really are stuck on having covered=booth be a thing, I could make a separate preset for "phone booth" that adds covered=booth? Rather than adding another state to the covered=yes/no field?

I'll ask the tagging@ list what they prefer, then will just decide something if we don't have any resolution after after a few days.

@bhousel bhousel added the waitfor-consensus Waiting for OpenStreetMap consensus label Jun 17, 2018
@eehpcm
Copy link
Author

eehpcm commented Jun 17, 2018

I'm not fixated on covered=booth. I used it because that's what the wiki suggested. I suspect the wiki suggests it because that's what people used for lack of anything better. You're right, it doesn't really fit in with the primary use of covered=, although a phone could coincidentally be placed where covered= does apply.

I've no problem with a new tag. Phones aren't (currently, on OSM carto) rendered differently whether or not they have covered=booth, so a change won't break any rendering expectations. And it would be ripe for automated replacement at the same time.

The wiki description about booth=k2/k6 isn't that useful. It's applicable only to the UK (and a few other countries which adopted UK phone booths), and links to a wikipedia article on red telephone boxes. But the old red phone boxes have been phased out in the UK itself and only a few are left. These days they're usually in the KX series. Few people could identify any of the specific models without a reference guide (I couldn't). Maybe what we need is booth=yes/no and a booth:type=* for those with obsessive mapping disorder. :)

And then to pour cold water on the idea, what about phones in the US which often aren't in booths but have a hood (is that the correct terminolgy)? And what do other countries have?

@Nakaner
Copy link

Nakaner commented Jun 19, 2018

covered=yes/no/booth was added to the English wiki page by user AssetBurned on 2 May 2010. Usage of this tag started in early May 2010. I did not look who used the tag.

@bhousel bhousel removed the waitfor-consensus Waiting for OpenStreetMap consensus label Jun 24, 2018
@bhousel
Copy link
Member

bhousel commented Jun 24, 2018

Ok we had an extensive discussion on the tagging list that ended up inconclusive.

I've decided to just leave the covered field as a yes/no checkbox.
I've also added a booth=* dropdown field, so people can add that detail if they want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants