Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to improve entrance searchability #5130

Merged
merged 1 commit into from
Jul 8, 2018

Conversation

tohaklim
Copy link
Contributor

@tohaklim tohaklim commented Jul 7, 2018

I am currently unable to bring-up entrance by typing in "entrance" on a vertex, this might help?

I am currently unable to bring-up entrance by typing in "entrance" on a vertex, this might help?
@JamesKingdom
Copy link
Collaborator

Just typing ent is enough to bring it up for me.
iD already matches the preset name without having it in terms, are you sure it was on a vertex?

@tohaklim
Copy link
Contributor Author

tohaklim commented Jul 7, 2018

I am guessing this has something to do with my browser locale not being English (and hence iD not being in English either). For some tags, just typing tag or key values works fine, but not for entrance

@bhousel
Copy link
Member

bhousel commented Jul 8, 2018

Oh interesting, typing 'ent' should match this rule because it is the leading word in the tag key, but doesn't because of the *. I don't know why it works this way, but this PR to add the terms should help.

var leading_tag_values = _filter(searchable, function(a) {
return _some(_without(_values(a.tags || {}), '*'), leading);
});

@bhousel bhousel merged commit ed7c652 into openstreetmap:master Jul 8, 2018
@tohaklim tohaklim deleted the patch-2 branch July 8, 2018 10:46
@tohaklim
Copy link
Contributor Author

tohaklim commented Aug 4, 2018

For some reason that didn’t fix the issue. Not a deal breaker so I’ll leave this for now, might look into it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants